Use Apache's ErrorLog when using mod_perl/vhosts

RESOLVED FIXED in Bugzilla 4.2

Status

()

Bugzilla
Administration
--
enhancement
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Christian Ruppert, Assigned: Christian Ruppert)

Tracking

unspecified
Bugzilla 4.2
Bug Flags:
approval +

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0) Gecko/20110322 Firefox/4.0
Build Identifier: 

All errors will be logged in apache's global error log instead of the ErrorLog of the specified vhost. See URL for further information.

Reproducible: Always

Updated

7 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 1

7 years ago
Created attachment 521259 [details] [diff] [review]
0001-Use-apache-s-ErrorLog.patch

We're using this patch currently

Updated

7 years ago
Attachment #521259 - Flags: review?(mkanat)

Comment 2

7 years ago
Comment on attachment 521259 [details] [diff] [review]
0001-Use-apache-s-ErrorLog.patch

Review of attachment 521259 [details] [diff] [review]:
-----------------------------------------------------------------

::: mod_perl.pl
@@ +56,5 @@
>  use Bugzilla::Template ();
>  use Bugzilla::Util ();
>  
> +use Apache2::Log ();
> +*CORE::GLOBAL::warn = \&Apache2::ServerRec::warn;

Looks good. We should put the CORE::GLOBAL::warn in a BEGIN block, though. That can be done on checkin.
Attachment #521259 - Flags: review?(mkanat) → review+

Comment 3

7 years ago
It's *sort* of a bug that log messages go to the wrong place. At least 4.2 should get this fix.
Flags: approval+
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → Bugzilla 4.2

Updated

7 years ago
Assignee: administration → idl0r
Status: NEW → ASSIGNED

Comment 4

7 years ago
mkanat, as you reviewed the patch and a fix on checkin is needed, could you please commit this patch yourself?

Comment 5

7 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified mod_perl.pl
Committed revision 7860.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.