Closed
Bug 643925
Opened 14 years ago
Closed 14 years ago
improve 503 response in maintenance mode
Categories
(Bugzilla :: Bugzilla-General, enhancement)
Bugzilla
Bugzilla-General
Tracking
()
RESOLVED
FIXED
Bugzilla 4.2
People
(Reporter: bjoern, Assigned: bjoern)
Details
Attachments
(1 file)
|
566 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:2.0.0) Gecko/20100101 Firefox/4.0
Build Identifier:
according to http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.5.4 a http 503 status without retry-after header is like a http 500 status, therefore I suggest the patch from
https://bug639367.bugzilla.mozilla.org/attachment.cgi?id=520924
to be added. This adds a "retry-after 1 day" when we return the 503 status in maintenance mode.
Reproducible: Always
|
||
Comment 1•14 years ago
|
||
Awesome. Could you attach the patch to this bug and request review here? It's easier to keep track of that way.
Assignee: general → bjoern
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 4.2
here it's once more ...
Attachment #521041 -
Flags: review?(mkanat)
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 521041 [details] [diff] [review]
bugzilla-http-service-unavailable-in-maintenance-mode-with-retry-time.patch
Okay, this looks good, but we should make it a constant and remove the quotes. I can do that on checkin. Also, I think I will make it an hour instead--most installations aren't down for very long when they are down.
Attachment #521041 -
Flags: review?(mkanat) → review+
|
|
||
Comment 4•14 years ago
|
||
Thank you so much for the patch, Bjoern! :-)
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla.pm
Committed revision 7758.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
please have a look at the http header with/without the quotes. Without the quotes I had the number twice, comma separated. With quotes the value was looking sane.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Max, did you double check that your modification is correct? As mentioned, this did not work for me.
|
|
||
Comment 7•14 years ago
|
||
Hey Bjoern. Yep, just tried and got this:
HTTP/1.1 503 Service Temporarily Unavailable
Date: Wed, 03 Aug 2011 01:05:44 GMT
Server: Apache/2.2.3 (CentOS)
X-frame-options: SAMEORIGIN
Retry-after: 3600
Connection: close
Content-Type: text/html; charset=UTF-8
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•