Closed
Bug 643966
Opened 13 years ago
Closed 13 years ago
test failure from warning about id-less widget
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: myk, Assigned: ochameau)
References
Details
Attachments
(1 file)
|
596 bytes,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
The test runner is currently reporting a failure in addon-kit tests without identifying the test that failed, and all tests on which it reports appears to have passed.
--------------------------------------------------------------------------------
(addon-sdk)myk@myk:~/addon-sdk/packages/addon-kit$ cfx test
Using binary at '/home/myk/bin/firefox'.
Using profile at '/tmp/tmpqf6M_h.mozrunner'.
Running tests on Firefox 4.0b13pre/Gecko 2.0b13pre ({ec8030f7-c20a-464f-9b0e-13a3a9e97384}) under Linux/x86-gcc3.
...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................console: [JavaScript Error: "(null)" {file: "jar:file:///home/myk/Applications/firefox-trunk/omni.jar!/chrome/toolkit/content/global/about.xhtml" line: 54 column: 44 source: "<html xmlns="http://www.w3.org/1999/xhtml">"}]
.........................................................................................................................................................info: onmessage...
.info: onmessage...
........................................................................................................................................................................................warning: You have to define an unique "id" attribute to your widget in order to be able to remember its position.
......console: [JavaScript Warning: "setting a property that has only a getter" {file: "resource://addon-kit-api-utils-lib/securable-module.js -> resource://addon-kit-api-utils-lib/securable-module.js -> resource://addon-kit-addon-kit-lib/widget.js" line: 279}]
.................................................error: warnings and/or errors were logged.
1092 of 1093 tests passed.
FAIL
Total time: 41.740156 seconds
Program terminated unsuccessfully.
--------------------------------------------------------------------------------
Turning on verbose mode doesn't help. The runner still reports a test failure but doesn't identify the test.
The problem appears to be cross-platform, and Ayan and I both see it.
Does anyone know what's going on here?
|
Assignee | |
Comment 1•13 years ago
|
||
In fact, it's not that clear but the error why it failed is mentioned here: error: warnings and/or errors were logged. So it fails because of widget warning. Let me some minutes to provide a patch. This failure is due to a new test added after widget.id attribute commit.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #521065 -
Flags: review?(myk)
|
Reporter | |
Comment 3•13 years ago
|
||
Comment on attachment 521065 [details] [diff] [review] Fix new widget test (noRightClick) I had trouble applying the patch: (addon-sdk)myk@myk:~/Projects/addon-sdk$ git apply ~/fix-widget-test.patch fatal: corrupt patch at line 12 Nevertheless, that could be a bug on my end, and applying it manually worked fine. r=myk, thanks for the quick fix!
Attachment #521065 -
Flags: review?(myk) → review+
|
|
Reporter | |
Comment 4•13 years ago
|
||
(In reply to comment #3) > I had trouble applying the patch: > > (addon-sdk)myk@myk:~/Projects/addon-sdk$ git apply ~/fix-widget-test.patch > fatal: corrupt patch at line 12 It looks like this is because of a missing newline on the last line of the file.
|
|
Reporter | |
Comment 5•13 years ago
|
||
Landed: https://github.com/mozilla/addon-sdk/commit/09d5b130ab6fb848eb192a92e698a8231ad33eaa Cherry-picked: https://github.com/mozilla/addon-sdk/commit/6b272befd4886b33e77b0dce92e0b49ca97dab80 We typically don't ship with known consistent test failures, making this a blocker.
Assignee: nobody → poirot.alex
Blocks: 642183
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Summary: test runner reports addon-kit failure without identifying it → test failure from warning about id-less widget
You need to log in
before you can comment on or make changes to this bug.
Description
•