643980 - test runner fails to start with Firefox 4 final host app

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: update the max version flags

When you try to run tests with Firefox 4 final as the host application, the runner fails to start running tests.  It looks like this is because the runner's compatibility max version is still set to 4.0b8pre.

That's ok for testing against nightly builds, even though they're now at 4.0b13pre, because python-lib/cuddlefish/prefs.py sets extensions.checkCompatibility.4.0b to false.  It only fails when testing against the Firefox final builds.

Here's a patch that updates the max version flags.  It also removes stated compatibility with Fennec and Thunderbird, as we previously did for addons created with the SDK, given that we currently have no development nor testing efforts for those host applications and do not expect them to be compatible.

This has to block 1.0b4, unfortunately, since we can't ship it two days after the Firefox 4 release with testing against that release broken.  So we'll have to spin a third RC to take this change.

Dietrich or Drew: can you review?  I really just need one review, but I'm requesting one from each of you to increase the chances of a quick review, since we'd need to spin an RC3 soon to make our current targeted release date of Thursday, March 24.

Comment 1

[Drew Willcoxon :adw]

Comment on attachment 521066 [details] [diff] [review]
update the max version flags

r+!  Best patch ever!

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Erm, how lame of me.  It looks like I was actually testing in an out-of-date tree. After fixing that problem, I no longer have the primary problem, since that install.rdf file identifies the Firefox max version correctly.

The application.ini file is still incorrect, however, saving this bug from being completely invalid.  So I have landed that part:

https://github.com/mozilla/addon-sdk/commit/b4d78455166005ae89d1bb40b2794965a8d3a2f2

And cherry-picked it to the 1.0b4 branch (as a low-risk fix, although it is no longer a blocker):

https://github.com/mozilla/addon-sdk/commit/eca8a0c095d8f8d59e16425518d33a6c92af6a14