Closed
Bug 644052
Opened 13 years ago
Closed 13 years ago
Refactor keyword generation
Categories
(Camino Graveyard :: Location Bar & Autocomplete, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
Details
Attachments
(1 file)
|
36.61 KB,
patch
|
Details | Diff | Splinter Review |
The new autocomplete ranking introduced an object to generate scores for items; I realized while writing it that having a similar object for generating keywords would be better more consistent, and also let me cleanly refactor a bunch of code out of AutoCompleteDataSource, which has taken on quite a few responsibilities during this whole autocomplete restructuring.
|
Assignee | |
Comment 1•13 years ago
|
||
Another after-the-fact sr for you, in case you get bored with the others ;) Basically this just moves code out of ACDS into the new object, tweaks the Trie to use the new object, and does a bit of refactoring of the moved code to make it (and the new object's API) cleaner.
Attachment #521112 -
Flags: superreview?(mikepinkerton)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Landed as http://hg.mozilla.org/camino/rev/af8e781f8184
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•12 years ago
|
Attachment #521112 -
Flags: superreview?(mikepinkerton)
You need to log in
before you can comment on or make changes to this bug.
Description
•