Closed Bug 644058 Opened 13 years ago Closed 1 month ago

Make it hard to do the wrong thing with PreferenceManager sharedInstance

Categories

(Camino Graveyard :: Preferences, defect)

Product:
Camino Graveyard
Component:
Preferences
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Details

Given bug 644057 and all its previous friends and relations, we should be doing something smarter. Specifically, there are only one or two places where it makes sense to be creating a pref manager, given that we make one early on in startup.

What we should do, to prevent repeatedly shooting ourselves in the feet, is have sharedInstance *not* create a new one, and have an explicit call to populate it (createSharedInstance or something).

The only tricky part will be ensuring that we don't have places we currently need prefs before ensureGeckoInitted; given the complexity of the startup code (since there are at least two or three ways for us to be launched), it's likely that we do at the moment.
Assignee: nobody → stuart.morgan+bugzilla
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.