Closed Bug 64417 Opened 23 years ago Closed 23 years ago
saving draft while offline needs to go to the offline draft store
If you are offline, and you save a draft message, and your draft folder is an imap folder, the draft needs to get saved in the offline store for the draft folder, and uploaded to the online draft folder when you go online (or select the drafts folder while online). Either that, or we should disable save as draft in this situation, which is what might happen since this is a little bit of a hard problem. Filing this bug to track this issue.
Status: NEW → ASSIGNED
Priority: -- → P2
moving to 0.9.2
Target Milestone: --- → mozilla0.9.2
I played around with this a bit. You can't save as draft to an imap folder when offline. You get an error message so it's not dataloss because the user is warned. You can save as draft to a local folder, so if the message really needs to be saved the user can switch their Drafts folder while writing that message. The can also do save as file. I think this could be release noted. David is looking into 82476 so that when going online the Drafts folder is reusable again.
So, would this be the same bug for not being able to store copy to online Sent folder while offline, or do we have/want a separate bug for Sent copies?
Sending unsent messages (after doing a send later) should do the copy the sent folder. Send Later should *not* put messages in the sent folder; the messages ahve not been sent yet. Is Send Unsent Messages not doing fcc? If so, that should be its own bug.
Well, Send Later when offline gives the error about copying to Sent folder if the Sent copy pref is set to online folder. Will double-check Send Unsent and report back here and log a separate bug if appropriate. Thanks for reiterating the correct process, David -- I wasn't thinking it through (holiday brain lag).
Send Unsent is indeed copying to sent folder properly. When offline, we do throw the error about the sent folder copy if the pref points to online folder, so that's a bug. It appears that the error doesn't happen when offline if we've sent a message and accessed that online sent folder while online (before going offline)... I'm trying this more times to make sure. Will log a bug about the copy to sent folder error on sending later while offline.
Whiteboard: [nsbeta1+] → [nsbeta1+][PDT+]
I've got the fixes coded for this and am testing them out.
Whiteboard: [nsbeta1+][PDT+] → [nsbeta1+][PDT+]Fix coded - testing
this still needs to get fixed, but moving to 0.9.3 so David can work on this.
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Whiteboard: [nsbeta1+][PDT+]Fix coded - testing → [nsbeta1+]Fix coded - testing
adding Seth and Navin to cc list - need review before checking into trunk. Code is pretty much self-explanatory - when we save a draft while offline, it goes into the local offline store (and gets run through a msg parser so we can build up a header). Then, when we go offline, we copy the msg to a temp file and then append it to the drafts folder. TIA.
r=naving. looks like some clean up is also being done, that's ok.
JF, how hard would it be to disable save as draft if we're offline and the user/identity is set to a user who has an online drafts folder? This patch is just too big and risky to go in at this late date and we might need to just punt and disable save as draft when offline and the drafts folder is online.
removing the nsbranch. We still need to figure out if we can disable this or if we just let it fail.
david, this should be fixed in your tree.
the patch has rotted, I'm sure. I'll have to try to recreate it.
adding nsenterprise keyword
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Commercial builds 2001082008 - win nt 4.0 2001082108 - linux 2.2, mac 9.0.4 If you are offline -you can save a draft to a imap drafts folder -no error occurrs -a message appears at the bottom of the message window saying 'copy complete' -i can go back and edit draft and resave it while offline -have access to draft if i go back online David, I noticed a couple of things: Observation 1: -when you create a brand new profile and then setup your imap mail account -there is no 'drafts' folder initially in the folder pane under my imap mail account. -if i click twisty, it doesn't refresh it -if I go to the File|subscribe window, there is no 'drafts' folder to check -the only way to create a drafts folder is to first save a draft while online -if I try to save a draft while offline (before drafts folder is created online), it will just hang as it says trying to to copy message to drafts folder -this is outliner bug? Observation 2: -when you first initially go offline -save a draft offline -go back online a message appears: "Alert: The current command did not succeed, The mail server responded: Invalid Sequence in UID" -if I repeat the steps again, the message does not appear again. (sometimes not repeatable as I try it again and can't get the error message) Observation 3: I noticed if I save a draft while online and also save a draft while offline (both to the drafts folder in my imap mail account), if I toggle between my inbox and drafts folder (while online) the 'online saved draft' dissapears and then reappears each time I toggle back and forth If you feel those are seperate bugs, I will file them. Just wanted to double check with you, before I mark as verified. The fix works as expected: users can save a draft to a imap drafts folder while offline.
#1 is the correct, desired behaviour, and not a bug. 2 and 3 are new bugs, I guess, though I haven't seen them.
Cool. Thanks David. Marking as verified. Will file new bugs on the last 2 things.
Status: RESOLVED → VERIFIED
Note: tried to reproduce my observations 2 and 3 in my comments on 2001-08-21 20:23. Couldn't replicate it. So no new bugs will be filed.
You need to log in before you can comment on or make changes to this bug.