644186 - Shift-clicking the "Open a new tab" button should open a new window

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Michael Dudley]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0

Shift-clicking the "Open a new tab" button on the tab bar should open a new window. I like the new minimalistic look in Firefox 4, and I'd prefer not to add a big custom button to the main toolbar or up next to the tab bar.

Having a button to open a new window allows me to do so in a single click, unlike the File menu. Using the keyboard shortcut (CTRL+N) requires me to move my hand from the mouse to the keyboard, which also slows me down.

Reproducible: Always

Steps to Reproduce:
1. Hold Shift key and left-click the "Open a new tab" button on the tab bar.

Actual Results:  
A new tab is opened.

Expected Results:  
A new window is opened.

Comment 1

[Willian Gustavo Veiga]

Attachment: 644186-shift-clicking-the-open-a-new-tab-button-opens-new-window.patch

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8357732 [details] [diff] [review]
644186-shift-clicking-the-open-a-new-tab-button-opens-new-window.patch

>+  if (event.shiftKey) {
>+    openUILinkIn(BROWSER_NEW_TAB_URL, "window");

Seems like this should be consistent with Ctrl+N / File -> New Window and just call OpenBrowserWindow.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

But that would then probably lead to confusing behavior due to bug 725579.

Comment 4

[Willian Gustavo Veiga]

Attachment: 644186-shift-clicking-the-open-a-new-tab-button-opens-new-window.patch

Comment 5

[Dão Gottwald [:dao]]

Changing that is entirely up to bug 725579. Making different methods of opening a new window behave differently just adds to the confusion.

Comment 6

[Manish Goregaokar [:manishearth]]

Comment on attachment 8357736 [details] [diff] [review]
644186-shift-clicking-the-open-a-new-tab-button-opens-new-window.patch

Review of attachment 8357736 [details] [diff] [review]:
-----------------------------------------------------------------

Tested, seems to work :)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/1c336f77bb50

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c336f77bb50

Comment 9

[Tracy Walker [:tracy]]

Verified fixed on latest Nightly.