Closed Bug 64419 Opened 24 years ago Closed 24 years ago

Add "#localization note" to editor.properties file to explain accesskey for 'Discontinue Link'

Categories

(Core :: Internationalization: Localization, defect)

Product:
Core
Component:
Internationalization: Localization
Platform:
Other
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.8

People

(Reporter: karl, Assigned: cmanske)

Details

(Keywords: l12y)

Attachments

(1 file)

Added localization notes
846 bytes, patch
Details | Diff | Splinter Review
The accesskey for 'Discontinue Link' in Composer isn't currently localizable.
Keywords: l12y, nsbeta1
Yes it is. The strings for the menu items and the accesskey is in editor.properties. It is using the same accesskey as for "RemoveLinks": "RemoveLinksAccesskey" ("n"in English). The menu text is changed dynamically and the accesskey key is reset at that time. Both strings ("Remove Links" and "Discontinue Link" in English) should contain the work "Link" and thus the accesskey should be from that word. This should be localizable. There's still a bug (41974) that prevents the accesskey from displaying correctly. The same strategy is used to share the accesskey for "Remove All Text Styles" and "Discontinue Text Styles", which both use "x" in English. Should we simply add a "#LOCALIZATION NOTE" in editor.properties to explain this behavior?
> Should we simply add a "#LOCALIZATION NOTE" in > editor.properties to explain this behavior? Yes! It's very difficult to know which accesskey applies when the label and accesskey don't share the same name.
cmanske: I thought bug 41974 was fixed a while back. Are you still seeing this? If not, can you mark it fixed?
I'll add explanatory comments to editor.properties
Status: NEW → ASSIGNED
Summary: Accesskey for 'Discontinue Link' not localizable → Add "#localization note" to editor.properties file to explain accesskey for 'Discontinue Link'
Target Milestone: --- → mozilla0.8
Reassigned to cmanske@netscape.com
Assignee: rchen → cmanske
Status: ASSIGNED → NEW
Review needed -- thanks.
Status: NEW → ASSIGNED
r=timeless, but shouldn't StopLinks=Discontinue Link be outside of the RemoveLinks segment?
Keywords: approval, patch, review
I'm not sure what you mean, but I will reorder the lines so related items are clearly next to each other.
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: