Closed Bug 644245 Opened 13 years ago Closed 13 years ago

Code cleanup

Categories

(Cloud Services :: Server: Share, defect)

Product:
Cloud Services
Component:
Server: Share
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tarek, Assigned: rmiller)

Details

Attachments

(2 files)

Pointer to Github pull request: https://github.com/mozilla/f1/pull/116#
337 bytes, text/html
tarek
: review+
Details
Pointer to Github pull request: https://github.com/mozilla/f1/pull/120
334 bytes, text/html
tarek
: review+
Details 
There are a few places to clean up 

$ flake8 linkdrop
linkdrop/csrf.py:27:80: E501 line too long (83 characters)
linkdrop/csrf.py:31:1: E302 expected 2 blank lines, found 1
linkdrop/csrf.py:86:13: E301 expected 1 blank line, found 0
linkdrop/debug.py:24: 'sys' imported but unused
linkdrop/debug.py:24: 'time' imported but unused
linkdrop/debug.py:24: 'os' imported but unused
linkdrop/debug.py:32: redefinition of unused 'Profile' from line 29
linkdrop/debug.py:34: redefinition of unused 'Profile' from line 32
linkdrop/debug.py:89: undefined name '_profiler'
linkdrop/debug.py:91: undefined name '_profiler'
linkdrop/debug.py:165: redefinition of unused 'sys' from line 24
linkdrop/debug.py:165: redefinition of unused 'os' from line 24
linkdrop/debug.py:165: redefinition of unused 'time' from line 24
linkdrop/debug.py:176: local variable 'count' is assigned to but never used
linkdrop/debug.py:196: local variable 'prof' is assigned to but never used
linkdrop/debug.py:24:11: E401 multiple imports on one line
linkdrop/debug.py:103:1: W291 trailing whitespace
linkdrop/debug.py:134:58: E231 missing whitespace after ','
linkdrop/debug.py:297:1: W391 blank line at end of file
linkdrop/debug.py:140:1: 'ProfilerMiddleware.__call__' is too complex (17)
linkdrop/static.py:2: 'sys' imported but unused
linkdrop/static.py:66:28: E261 at least two spaces before inline comment
linkdrop/static.py:31:1: 'StaticURLParser.__call__' is too complex (11)
linkdrop/tests/__init__.py:12: 'loadapp' imported but unused
linkdrop/tests/functional/test_send.py:23: 'urllib2' imported but unused
linkdrop/tests/functional/util.py:173: 'OperationalError' imported but unused
linkdrop/tests/functional/util.py:576: undefined name 'OperationalError'
linkdrop/tests/functional/util.py:66:1: E303 too many blank lines (4)
linkdrop/config/environment.py:31: 'asbool' imported but unused
linkdrop/controllers/contacts.py:25: 'urllib' imported but unused
linkdrop/controllers/contacts.py:25: 'cgi' imported but unused
linkdrop/controllers/contacts.py:25: 'sys' imported but unused
linkdrop/controllers/contacts.py:26: 'urlparse' imported but unused
linkdrop/controllers/contacts.py:28: 'config' imported but unused
linkdrop/controllers/contacts.py:28: 'response' imported but unused
linkdrop/controllers/contacts.py:28: 'c' imported but unused
linkdrop/controllers/contacts.py:28: 'url' imported but unused
linkdrop/controllers/contacts.py:29: 'abort' imported but unused
linkdrop/controllers/contacts.py:29: 'redirect' imported but unused
linkdrop/controllers/contacts.py:30: 'jsonify' imported but unused
linkdrop/controllers/contacts.py:31: 'get_pylons' imported but unused
linkdrop/controllers/contacts.py:33: 'render' imported but unused
linkdrop/controllers/contacts.py:37: 'constants' imported but unused
linkdrop/controllers/contacts.py:128: local variable 'e' is assigned to but never used
linkdrop/controllers/contacts.py:87:75: E202 whitespace before ')'
linkdrop/controllers/contacts.py:115:90: E225 missing whitespace around operator
linkdrop/controllers/send.py:25: 'datetime' imported but unused
linkdrop/controllers/send.py:27: 'urllib' imported but unused
linkdrop/controllers/send.py:28: 'sys' imported but unused
linkdrop/controllers/send.py:29: 'httplib2' imported but unused
linkdrop/controllers/send.py:35: 'config' imported but unused
linkdrop/controllers/send.py:35: 'response' imported but unused
linkdrop/controllers/send.py:36: 'abort' imported but unused
linkdrop/controllers/send.py:36: 'redirect' imported but unused
linkdrop/controllers/send.py:37: 'get_pylons' imported but unused
linkdrop/controllers/send.py:178: local variable 'e' is assigned to but never used
linkdrop/controllers/send.py:112:1: 'SendController.send' is too complex (10)
linkdrop/controllers/docs.py:30: 'response' imported but unused
linkdrop/controllers/docs.py:30: 'c' imported but unused
linkdrop/controllers/docs.py:30: 'url' imported but unused
linkdrop/controllers/docs.py:30: 'request' imported but unused
linkdrop/controllers/docs.py:30: 'session' imported but unused
linkdrop/controllers/docs.py:31: 'abort' imported but unused
linkdrop/controllers/docs.py:31: 'redirect' imported but unused
linkdrop/controllers/docs.py:33: 'render' imported but unused
linkdrop/controllers/docs.py:34: 'api_arg' imported but unused
linkdrop/controllers/docs.py:113: 'linkdrop' imported but unused
linkdrop/controllers/docs.py:59:14: E701 multiple statements on one line (colon)
linkdrop/controllers/docs.py:111:5: E304 blank lines found after function decorator
linkdrop/controllers/docs.py:111:1: 'DocsController.index' is too complex (11)
linkdrop/controllers/account.py:25: 'cgi' imported but unused
linkdrop/controllers/account.py:30: 'c' imported but unused
linkdrop/controllers/account.py:30: 'response' imported but unused
linkdrop/controllers/account.py:30: 'url' imported but unused
linkdrop/controllers/account.py:31: 'abort' imported but unused
linkdrop/controllers/account.py:32: 'jsonify' imported but unused
linkdrop/controllers/account.py:33: 'get_pylons' imported but unused
linkdrop/controllers/account.py:36: 'render' imported but unused
linkdrop/controllers/account.py:37: 'api_entry' imported but unused
linkdrop/controllers/account.py:37: 'api_arg' imported but unused
linkdrop/controllers/account.py:148: redefinition of unused 'url' from line 30
linkdrop/lib/helpers.py:35: 'literal' imported but unused
linkdrop/lib/helpers.py:70: 'entitydefs' imported but unused
linkdrop/lib/helpers.py:85:27: W601 .has_key() is deprecated, use 'in'
linkdrop/lib/helpers.py:175:1: 'api_entry' is too complex (23)
linkdrop/lib/shortener.py:27: 'url' imported but unused
linkdrop/lib/shortener.py:33: local variable 'longUrl' is assigned to but never used
linkdrop/lib/shortener.py:34: local variable 'bitly_userid' is assigned to but never used
linkdrop/lib/shortener.py:35: local variable 'bitly_key' is assigned to but never used
linkdrop/lib/shortener.py:41: local variable 'e' is assigned to but never used
linkdrop/lib/base.py:29: 'render' imported but unused
linkdrop/lib/oauth/facebook_.py:30: redefinition of unused 'parse_qs' from line 28
linkdrop/lib/oauth/facebook_.py:30: 'parse_qs' imported but unused
linkdrop/lib/oauth/facebook_.py:38: 'response' imported but unused
linkdrop/lib/oauth/facebook_.py:38: 'c' imported but unused
linkdrop/lib/oauth/facebook_.py:38: 'request' imported but unused
linkdrop/lib/oauth/facebook_.py:38: 'session' imported but unused
linkdrop/lib/oauth/facebook_.py:39: 'abort' imported but unused
linkdrop/lib/oauth/facebook_.py:39: 'redirect' imported but unused
linkdrop/lib/oauth/facebook_.py:28:6: E111 indentation is not a multiple of four
linkdrop/lib/oauth/facebook_.py:64:1: 'extract_fb_data' is too complex (11)
linkdrop/lib/oauth/twitter_.py:26: 'urlparse' imported but unused
linkdrop/lib/oauth/twitter_.py:28: 'httplib2' imported but unused
linkdrop/lib/oauth/twitter_.py:29: 'oauth' imported but unused
linkdrop/lib/oauth/twitter_.py:33: 'config' imported but unused
linkdrop/lib/oauth/twitter_.py:33: 'response' imported but unused
linkdrop/lib/oauth/twitter_.py:33: 'c' imported but unused
linkdrop/lib/oauth/twitter_.py:33: 'url' imported but unused
linkdrop/lib/oauth/twitter_.py:33: 'request' imported but unused
linkdrop/lib/oauth/twitter_.py:33: 'session' imported but unused
linkdrop/lib/oauth/twitter_.py:34: 'abort' imported but unused
linkdrop/lib/oauth/twitter_.py:34: 'redirect' imported but unused
linkdrop/lib/oauth/twitter_.py:155: local variable 'ee' is assigned to but never used
linkdrop/lib/oauth/twitter_.py:79:25: E201 whitespace after '['
linkdrop/lib/oauth/yahoo_.py:34: 'session' imported but unused
linkdrop/lib/oauth/yahoo_.py:34: 'response' imported but unused
linkdrop/lib/oauth/yahoo_.py:34: 'url' imported but unused
linkdrop/lib/oauth/yahoo_.py:35: 'redirect' imported but unused
linkdrop/lib/oauth/yahoo_.py:35: 'abort' imported but unused
linkdrop/lib/oauth/yahoo_.py:42: 'UIRequest' imported but unused
linkdrop/lib/oauth/yahoo_.py:43: 'alternate_ax_attributes' imported but unused
linkdrop/lib/oauth/yahoo_.py:148: redefinition of unused 'response' from line 34
linkdrop/lib/oauth/yahoo_.py:198: local variable 'result' is assigned to but never used
linkdrop/lib/oauth/yahoo_.py:198: local variable 'error' is assigned to but never used
linkdrop/lib/oauth/yahoo_.py:201: local variable 'from_email' is assigned to but never used
linkdrop/lib/oauth/google_.py:31: 're' imported but unused
linkdrop/lib/oauth/google_.py:37: 'OPENID1_NS' imported but unused
linkdrop/lib/oauth/google_.py:37: 'no_default' imported but unused
linkdrop/lib/oauth/google_.py:37: 'IDENTIFIER_SELECT' imported but unused
linkdrop/lib/oauth/google_.py:37: 'BARE_NS' imported but unused
linkdrop/lib/oauth/google_.py:37: 'Message' imported but unused
linkdrop/lib/oauth/google_.py:52: 'session' imported but unused
linkdrop/lib/oauth/google_.py:52: 'response' imported but unused
linkdrop/lib/oauth/google_.py:52: 'url' imported but unused
linkdrop/lib/oauth/google_.py:53: 'redirect' imported but unused
linkdrop/lib/oauth/google_.py:53: 'abort' imported but unused
linkdrop/lib/oauth/google_.py:60: 'alternate_ax_attributes' imported but unused
linkdrop/lib/oauth/google_.py:259: redefinition of unused 'url' from line 52
linkdrop/lib/oauth/google_.py:354: undefined name 'logger'
linkdrop/lib/oauth/google_.py:390: redefinition of unused 'url' from line 52
linkdrop/lib/oauth/google_.py:405: local variable 'accounts' is assigned to but never used
linkdrop/lib/oauth/google_.py:418: redefinition of unused 'url' from line 52
linkdrop/lib/oauth/google_.py:422: redefinition of unused 'url' from line 52
linkdrop/lib/oauth/google_.py:430: redefinition of unused 'url' from line 52
linkdrop/lib/oauth/google_.py:250:1: 'api.sendmessage' is too complex (11)
linkdrop/lib/oauth/openidconsumer.py:28: 'pape' imported but unused
linkdrop/lib/oauth/openidconsumer.py:32: 'response' imported but unused
linkdrop/lib/oauth/openidconsumer.py:32: 'c' imported but unused
linkdrop/lib/oauth/openidconsumer.py:33: 'abort' imported but unused
linkdrop/lib/oauth/openidconsumer.py:214: undefined name 'sql_connstring'
linkdrop/lib/oauth/openidconsumer.py:214: undefined name 'sql_associations_table'
linkdrop/lib/oauth/openidconsumer.py:214: undefined name 'sql_connstring'
linkdrop/lib/oauth/openidconsumer.py:268: undefined name 'end_point'
linkdrop/lib/oauth/openidconsumer.py:53:15: E251 no spaces around keyword / parameter equals
linkdrop/lib/oauth/openidconsumer.py:54:12: E221 multiple spaces before operator
linkdrop/lib/oauth/openidconsumer.py:125:1: 'extract_openid_data' is too complex (13)
linkdrop/lib/oauth/openidconsumer.py:308:1: 'OpenIDResponder.verify' is too complex (11)
linkdrop/lib/oauth/linkedin_.py:2: 'urlparse' imported but unused
linkdrop/lib/oauth/linkedin_.py:9: 'session' imported but unused
linkdrop/lib/oauth/linkedin_.py:9: 'response' imported but unused
linkdrop/lib/oauth/linkedin_.py:9: 'url' imported but unused
linkdrop/lib/oauth/linkedin_.py:9: 'request' imported but unused
linkdrop/lib/oauth/linkedin_.py:10: 'redirect' imported but unused
linkdrop/lib/oauth/linkedin_.py:10: 'abort' imported but unused
linkdrop/lib/oauth/linkedin_.py:11: 'asbool' imported but unused
linkdrop/lib/oauth/linkedin_.py:114: redefinition of unused 'url' from line 9
linkdrop/lib/oauth/linkedin_.py:129: redefinition of unused 'url' from line 9
linkdrop/lib/oauth/linkedin_.py:132: local variable 'from_email' is assigned to but never used
linkdrop/lib/oauth/linkedin_.py:172: redefinition of unused 'url' from line 9
linkdrop/lib/oauth/linkedin_.py:173: local variable 'method' is assigned to but never used
linkdrop/lib/oauth/linkedin_.py:175: redefinition of unused 'url' from line 9
linkdrop/lib/oauth/base.py:7: redefinition of unused 'parse_qs' from line 5
linkdrop/lib/oauth/base.py:8: 'json' imported but unused
linkdrop/lib/oauth/base.py:13: 'c' imported but unused
linkdrop/lib/oauth/base.py:13: 'response' imported but unused
linkdrop/lib/oauth/base.py:14: 'abort' imported but unused
linkdrop/lib/oauth/base.py:52: local variable 'force_login' is assigned to but never used

Will do it in a single patch
Assignee: tarek → rmiller
Pointer to Github pull-request
Attachment #523416 - Flags: review?(tarek)
Attachment #523416 - Flags: review?(tarek) → review+
Pointer to Github pull-request
Comment on attachment 525590 [details]
Pointer to Github pull request: https://github.com/mozilla/f1/pull/120

much better flake8 output now.  only stuff left is real code issues, not just formatting... leaving those for a different ticket, since it's riskier and i don't want to mix them in w/ a bunch of whitespace noise.
Attachment #525590 - Flags: review?(tarek)
Attachment #525590 - Flags: review?(tarek) → review+
pep8 and pyflakes are much happier now.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: