Remove spaces at end of lines in prtypes.h

RESOLVED FIXED in 4.8.8

Status

NSPR
NSPR
--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 521333 [details] [diff] [review]
Proposed patch

prtypes.h has several space characters at the end of lines.
The attached patch removes them.
Attachment #521333 - Flags: review?(mark)
Wan-Teh, you have often complained about other people's patches that change
things unnecessarily.  What necessitates the removal of trailing whitespace?
(Assignee)

Comment 2

7 years ago
A copy of prtypes.h is in the Chromium source tree to support a copy
of NSS's SHA-256 code.  Chromium doesn't allow spaces at end of line,
so Chromium developers often remove them, not realizing they're in
third-party code.  This makes it hard to update that copy of prtypes.h
with the NSPR upstream.

If you object, I can mark this bug WONTFIX.

Comment 3

7 years ago
Comment on attachment 521333 [details] [diff] [review]
Proposed patch

I generally support this sort of thing as long as it’s done in its own isolated patch and isn’t likely to break anyone else’s work in progress. This is an isolated patch, and it’s fairly unlikely to conflict with others’ work.
Attachment #521333 - Flags: review?(mark) → review+
(Assignee)

Comment 4

7 years ago
Patch checked in on the NSPR trunk (NSPR 4.8.8).

Checking in prtypes.h;
/cvsroot/mozilla/nsprpub/pr/include/prtypes.h,v  <--  prtypes.h
new revision: 3.44; previous revision: 3.43
done

I found that Chromium's cpplint.py script does not complain about
end-of-line whitespaces in the middle of a C comment block, so
those spaces in Chromium's copy of prtypes.h were probably removed
by someone whose editor was configured to automatically remove
end-of-line whitespaces.  I considered marking this WONTFIX, but
didn't want to waste more time on this.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: 4.8.9 → 4.8.8
You need to log in before you can comment on or make changes to this bug.