Posted to n.p.m.embedding:
Your message has been submitted to netscape.public.mozilla.embedding.
NOTE: If you made a mistake and need to cancel your message, you can cancel it
from our cancel page.
To do so you will need this Message-ID: <email@example.com>.
The reason for the assertion is that Preferences doesn't use ActionEvents.
I'm about to attach a checkpoint of the conversion of Prefs to actionEvents.
Created attachment 21904 [details]
Created attachment 21906 [details]
tar.gz of fix for this bug, first iteration.
Comments about Patch -
* Makefile.win and Makefile.in - ok
* PreferenceImpl.cpp -
you have code like - goto NSUP_CLEANUP everywhere in this file.
Instead of goto, you could define a macro for doing the cleanup + return
from function. Then you can just call that macro eveywhere instead of
* PreferenceActionEvents.cpp - same problem. goto should be avoided wherever
* PreferenceActionEvents.h - ok
pls let me know if you agree with these comments.
Ashu, I prefer to have a single return in each method, more so than a simple
local goto. In any case, this goto logic is used all over the code. If we're
going to change that strategy, we should do it everywhere. Given that, can I
please have r=?
Fix checked in.
Verified with mozilla branch NETSCAPE_6_2_RELEASE and blackwood sources from
trunk. Preferences works fine, I cannot see any assertions.
Changed QAContact and add myself to cc list.