0[91d5eb0]: ###!!! ASSERTION: nsScriptNameSetRegistry not thread-safe: 'owningTh

VERIFIED FIXED

Status

Core Graveyard
Java APIs to WebShell
VERIFIED FIXED
17 years ago
5 years ago

People

(Reporter: edburns, Assigned: edburns)

Tracking

Trunk
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

17 years ago
Posted to n.p.m.embedding:

Your message has been submitted to netscape.public.mozilla.embedding. 

NOTE: If you made a mistake and need to cancel your message, you can cancel it 
from our cancel page.
To do so you will need this Message-ID: <935mes$fr3$1@nnrp1.deja.com>. 

Status: NEW → ASSIGNED
(Assignee)

Comment 2

17 years ago
The reason for the assertion is that Preferences doesn't use ActionEvents.

I'm about to attach a checkpoint of the conversion of Prefs to actionEvents.
(Assignee)

Comment 3

17 years ago
Created attachment 21904 [details]
tar.gz checkpoint.
(Assignee)

Comment 4

17 years ago
Created attachment 21906 [details]
tar.gz of fix for this bug, first iteration.

Comment 5

17 years ago
Comments about Patch -
* Makefile.win and Makefile.in - ok
* PreferenceImpl.cpp -
  you have code like - goto NSUP_CLEANUP everywhere in this file.
  Instead of goto, you could define a macro for doing the cleanup + return
  from function. Then you can just call that macro eveywhere instead of
  using goto.  
* PreferenceActionEvents.cpp - same problem. goto should be avoided wherever
  possible.
* PreferenceActionEvents.h - ok

pls let me know if you agree with these comments. 
_Ashu
(Assignee)

Comment 6

17 years ago
Ashu, I prefer to have a single return in each method, more so than a simple 
local goto.  In any case, this goto logic is used all over the code.  If we're 
going to change that strategy, we should do it everywhere.  Given that, can I 
please have r=?

Thanks,

Ed

Comment 7

17 years ago
r=ashuk

(Assignee)

Comment 8

17 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 9

16 years ago
Verified with mozilla branch NETSCAPE_6_2_RELEASE and blackwood sources from 
trunk. Preferences works fine, I cannot see any assertions.
Changed QAContact and add myself to cc list.
Status: RESOLVED → VERIFIED
QA Contact: geetha.vaidyanaathan → avm
Component: Java APIs to WebShell → Java APIs to WebShell
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.