Last Comment Bug 64445 - 0[91d5eb0]: ###!!! ASSERTION: nsScriptNameSetRegistry not thread-safe: 'owningTh
: 0[91d5eb0]: ###!!! ASSERTION: nsScriptNameSetRegistry not thread-safe: 'owningTh
Product: Core Graveyard
Classification: Graveyard
Component: Java APIs to WebShell (show other bugs)
: Trunk
: x86 Windows NT
-- normal (vote)
: ---
Assigned To: edburns
: Alexei V. Mokeev
Depends on:
  Show dependency treegraph
Reported: 2001-01-05 15:47 PST by edburns
Modified: 2012-04-09 22:27 PDT (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

tar.gz checkpoint. (8.53 KB, application/octet-stream)
2001-01-05 18:24 PST, edburns
no flags Details
tar.gz of fix for this bug, first iteration. (11.73 KB, application/octet-stream)
2001-01-05 18:52 PST, edburns
no flags Details

Description User image edburns 2001-01-05 15:47:09 PST

Comment 1 User image edburns 2001-01-05 15:48:08 PST
Posted to n.p.m.embedding:

Your message has been submitted to netscape.public.mozilla.embedding. 

NOTE: If you made a mistake and need to cancel your message, you can cancel it 
from our cancel page.
To do so you will need this Message-ID: <935mes$fr3$>. 

Comment 2 User image edburns 2001-01-05 18:24:12 PST
The reason for the assertion is that Preferences doesn't use ActionEvents.

I'm about to attach a checkpoint of the conversion of Prefs to actionEvents.
Comment 3 User image edburns 2001-01-05 18:24:50 PST
Created attachment 21904 [details]
tar.gz checkpoint.
Comment 4 User image edburns 2001-01-05 18:52:18 PST
Created attachment 21906 [details]
tar.gz of fix for this bug, first iteration.
Comment 5 User image Ashu Kulkarni 2001-01-08 12:15:56 PST
Comments about Patch -
* and - ok
* PreferenceImpl.cpp -
  you have code like - goto NSUP_CLEANUP everywhere in this file.
  Instead of goto, you could define a macro for doing the cleanup + return
  from function. Then you can just call that macro eveywhere instead of
  using goto.  
* PreferenceActionEvents.cpp - same problem. goto should be avoided wherever
* PreferenceActionEvents.h - ok

pls let me know if you agree with these comments. 
Comment 6 User image edburns 2001-01-08 15:56:11 PST
Ashu, I prefer to have a single return in each method, more so than a simple 
local goto.  In any case, this goto logic is used all over the code.  If we're 
going to change that strategy, we should do it everywhere.  Given that, can I 
please have r=?


Comment 7 User image Ashu Kulkarni 2001-01-08 16:01:08 PST

Comment 8 User image edburns 2001-01-08 17:00:39 PST
Fix checked in.
Comment 9 User image Vladimir Strigun 2001-11-27 08:19:35 PST
Verified with mozilla branch NETSCAPE_6_2_RELEASE and blackwood sources from 
trunk. Preferences works fine, I cannot see any assertions.
Changed QAContact and add myself to cc list.

Note You need to log in before you can comment on or make changes to this bug.