64455 - Problem building Java components on Win 98/ME because of buildpkg.bat file

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Ashu Kulkarni]

mozilla/config/buildpkg.bat file uses pushd and popd which are available as
inbuilt shell commands on Win NT and Win 2000, but are not present in the 98/ME
line of Windows OSes.

Because of this, none of the Blackwood Java components can be built on Win98 or
WinME.

The patch below fixes this problem. I have tested it on WinNT and Win98/ME and
it works fine.


---------------------- suggested patch ---------------------
Index: mozilla/config/buildpkg.bat
===================================================================
RCS file: /cvsroot/mozilla/config/buildpkg.bat,v
retrieving revision 3.4
diff -u -r3.4 buildpkg.bat
--- buildpkg.bat        2000/03/23 02:36:03     3.4
+++ buildpkg.bat        2001/01/06 01:54:31
@@ -23,7 +23,7 @@
 if not exist %2\NUL echo Warning: %2 does not exist! (you may need to check it
out)
 if not exist %2\NUL exit 1
 
-pushd %2
+cd %2
 
 goto NO_CAFE
 
@@ -41,4 +41,4 @@
 
 :END
 
-popd
+

-------------------------end patch------------------------


I also have a r=edburns

Waiting for sr=

_Ashu

Comment 1

[Ashu Kulkarni]

Attachment: source file of new buildpkg.bat

Comment 2

[Ashu Kulkarni]

granrose, could you pls super-review...

thnx much
_Ashu

Comment 3

[Jon Granrose]

I can't sr.  cc leaf and cls for super review.

Comment 4

[Ashu Kulkarni]

Hello leaf,

could you pls check the patch and super review it.
thanks much

_Ashu

Comment 5

[Daniel (Leaf) Nunes]

the only problem i can see with this change is that it doesn't return the shell
back to the directory it started in (that's the whole reason for using pushd and
popd in the first place). I know that you are probably the only users of this
script... how are you testing the build on NT? Is the bat file leaving you in
the directory that you expect it to leave you when it's done running?

Comment 6

[Ashu Kulkarni]

we call mozilla/config/buildpkg from mozilla/config/javarules.mak
the script does leave us in the correct directory when it exits.
I have tested this on both NT and ME/98.

Comment 7

[cls]

*** Bug 65504 has been marked as a duplicate of this bug. ***

Comment 8

[Ashu Kulkarni]

Daniel,Christopher,
Do I have sr=leaf for this fix? We have Webclient users who
have reported problems building on Win98 because of this bug
and so I'd really like to check this in.
thanks much
_Ashu

Comment 9

[Daniel (Leaf) Nunes]

sr=leaf, sorry for the delay.

Comment 10

[Ashu Kulkarni]

Fix checked in -

----------- Begin checkin message ------------------

author=[e-mail]
r=[e-mail]
sr=[e-mail]

Bug - 64455

This fix allows the Java modules within Mozilla to Build on Win98
and Win ME. This fix modifies the file
mozilla/config/buildpkg.bat

The buildpkg.bat file contains pushd and popd which are shell 
utilities available under Win NT and Win 2K, but not in Win98
or Win ME. This caused the build to fail for the Java modules
like Blackwood (mozilla/java) on Win98/ME.

--- cvs diff -u of fix ----

Index: buildpkg.bat
===================================================================
RCS file: /cvsroot/mozilla/config/buildpkg.bat,v
retrieving revision 3.4
diff -r3.4 buildpkg.bat
26c26
< pushd %2
---
> cd %2
44d43
< popd

*****CVS exited normally with code 1*****

-------------- End checkin message --------------

Comment 11

[Jon Granrose]

verified.

Comment 12

[Alexei V. Mokeev]

*** Bug 56578 has been marked as a duplicate of this bug. ***