644582 - "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource://testpilot/modules/feedback.js :: FeedbackManager_isInputUrl :: line 109"

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect, P2)

Description

[alex_mayorga]

User-Agent:       Mozilla/5.0 (Windows NT 6.0; rv:2.2a1pre) Gecko/20110324 Firefox/4.2a1pre
Build Identifier: 

Loading any "special page" causes an error to appear in the error console.
Some pages:
about:blank
about:plugins
Add-ons Manager

Reproducible: Always

Steps to Reproduce:
1. Press Ctrl+Shift+A to load Add-ons Manager
2. Check the Errors tab in the Error Console
Actual Results:  
Error below is shown in the Error Console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.host]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://testpilot/modules/feedback.js :: FeedbackManager_isInputUrl :: line 109"  data: no]

Expected Results:  
No error appears

http://groups.google.com/group/mozilla-labs-testpilot/browse_thread/thread/fd91cd47e691989e/b3fa8801728f4791

Comment 1

[Jono Xia]

Hi Alex,
Thanks for reporting the bug.  I've seen this too.  It doesn't seem to affect anything, so I think we just need to be catch the error or else check whether it's a "special" URL before attempting to parse it.

Comment 2

[Jono Xia]

Fixed in http://hg.mozilla.org/labs/testpilot/rev/a875928fabfa

Comment 4

[Jono Xia]

Attachment: Patch to mozilla-central to fix this bug

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 524916 [details] [diff] [review]
Patch to mozilla-central to fix this bug

     if (uri.host == "input.mozilla.com") {
>+        if (path.indexOf("feedback" > -1) || path.indexOf("happy" > -1) || path.indexOf("sad" > -1)) {

You already fixed this parens bug in bug 645982

Otherwise looks OK

Comment 6

[Jono Xia]

mfinkle: Is this landed?  If it is I will close the bug.