64469 - biff doesn't work with pop

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[(not reading, please use [e-mail] instead)]

good news:  I have the fix.

Index: nsPop3Service.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/local/src/nsPop3Service.cpp,v
retrieving revision 1.60
diff -r1.60 nsPop3Service.cpp
109c109
<         char * urlSpec = PR_smprintf("pop3://%s@%s:%d?check", (const char
*)escapedUsername, (const char *)popHost, &popPort);
---
>         char * urlSpec = PR_smprintf("pop3://%s@%s:%d?check", (const char
*)escapedUsername, (const char *)popHost, popPort);


before, my fix, the pop biff url is:

"pop3://[e-mail]:-123132412?check"
that spec causes us to create a bad url, and later on we can't get the hostname
from the url, so we fail to biff.

after my fix, we get:

"pop3://[e-mail]:110?check"

and all is well.

this broke on Aug 31, before we shipped.  might be something to land on the
branch.

Comment 1

[(not reading, please use [e-mail] instead)]

fix checked in.

now biff (on pop) work on the trunk.  I think that one line fix is worth taking
on the branch.

Comment 2

[scottputterman]

Seth,

So I just tried POP biff on my NS6 release and it works fine for me.  Do you
have any idea why your particular account wouldn't work? I'm just trying to
figure out what types of users might be affected by the bug you are fixing.

Does your account work with an official release?

Comment 3

[scottputterman]

I guess since we're putting a ptr in the url, that could cause some randomness
and explain why it doesn't happen to me.  We have had people complain about biff
not working.  I just wanted to make sure that even though the incorrect code is
on the branch that it wasn't the case that we exposed the fact that it doesn't
work in other code after the branch was tagged.  If not, then it seems to me
that this bug would be pretty important to fix given the feedback we've had.
This is a really good catch.

Comment 4

[(not reading, please use [e-mail] instead)]

"I just wanted to make sure that even though the incorrect code is
on the branch that it wasn't the case that we exposed the fact that it doesn't
work in other code after the branch was tagged"

I don't understand.  can you clarify?

we have a few other biff bugs that would also give users the feeling that biff
wasn't working, see #64467 and #24594

Comment 5

[scottputterman]

What I meant was that it's possible that it could work in the branch and not the
trunk. The reason would be that for some reason the messed up url wasn't being
accessed by code that existed on the branch but by new code that was added after
the branch was tagged.

i.e.

8/31 bad code goes in but nothing takes advantage of the fact that it doesn't work
9/22 branch is tagged
9/23 code checked into trunk uses bad code

therefore the trunk is bad but the branch isn't.

This is the only reason besides the randomness mentioned above that I could
think of that my branch build works for me but the trunk doesn't work for you.
It sounds like it might be the randomness caused by the ptr value. If that's the
case I think we should check this in on the branch.

Comment 6

[Angela Butler]

Added branch accept to status whiteboard.
.Angela...

Comment 7

[Angela Butler]

Seth,  Could you check the fix into the branch A.S.A.P.?
.Angela...

Comment 8

[(not reading, please use [e-mail] instead)]

fix checked in to the branch.

Comment 9

[fenella]

Linux (2000-01-17-06 mtrunk)
Win32 (2000-01-17-06 mtrunk)
Mac (2000-01-17-08 mtrunk)
On Win32 Win_nt 4.0 and Mac, biff works with POP 
But on Linux, biff does not show up in Account and folder levels.

Comment 10

[fenella]

Re-test using 
Linux (2001-01-17-08 Mtrunk)

and branch builds:
Linux (2001-01-17-17 Mtest)
Win32 (2001-01-04-18 Mtest)
Mac  (2001-01-17-17 Mtest)
Biff works with POP.

Comment 11

[Håkan Waara]

*** Bug 25031 has been marked as a duplicate of this bug. ***

Comment 12

[Xiaobin Lu]

Validation on Solaris platform.
Tried on Netscape6 commerical build (03/15/2001) on x86Solaris 2.7 (with
min patch level) and sparc Solaris 2.8 (max. patch level).

Tag used:
 [tag: -r Netscape_6_0_OEM_BRANCH -D "03/06/2001 22:00:00"
 PSM: 1.4 (PSM_1_4_N6) & NSS 3.1 (NSS_3_1_RTM tag)


Does not seem to work
I used mail.biff.command to be set to a shell script in /tmp/mybiff.sh which is 
supposed to  print a dummy string in my prefs.js.
Invoked browser
Invoked Mailer. set up POP server 
Sent myself an email from command line.
it did not popup the alert with a dumy string.

Am I doing the right steps?

Comment 13

[(not reading, please use [e-mail] instead)]

mail.biff.command was a 4.x pref. 

it is not supported in 6.x