644782 - Allow ESCAPE to close autocomplete

Status: RESOLVED INVALID

(Mozilla Labs :: F1, defect)

Description

[James Burke]

Sometimes the contacts autocomplete is in the way, and with a normal autocomplete ESCAPE can git rid of it.

However, the panel seems to catch the ESCAPE call (on capture instead of bubble?) and the panel is closed instead. May need to look at add-on code to fix this.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

This seems hard - and now with Jetpack is doubly-hard :)

* In the XUL panel itself, keys are handled in the "capture" phase.  See http://mxr.mozilla.org/mozilla/source/layout/xul/base/src/nsXULPopupManager.cpp#1913, introduced via bug 400893.

* This code also handles menus, and the capture phase is used so content can't handle the keyboard interaction for menus.  However, this handling for panels seems to be an "implementation accident" - it isn't clear the ESC key for panels must also exclude content from messing with it.

* A panel does have an ignorekeys="true" flag to prevent this.  However, this isn't exposed via Jetpack and even if it was and could be adjusted dynamically, it would be a clumsy and error prone way to implement it.

The "most correct" course of action would probably to start a thread on dev-platform and see if it would be acceptable and/or possible to handle ESC for panels in the bubble phase specifically to allow content to override it as necessary.  This might not be the "best" for us though as it would mean it only works in later firefox versions.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

f1 is no longer an active project.  delete these messages by searching for: [closing_f1_project_bugs]

Comment 3

[eyal gruss]

i opened bug 1200852 to deal with this in the new social panel