644859 - Search doesn't find questions tagged with OS names

Status: RESOLVED FIXED

(support.mozilla.org :: Search, defect, P3)

Description

[[:Cww]]

https://support.mozilla.com/en-US/search?q=&is_locked=0&num_voted=0&num_votes=&asked_by=&answered_by=&q_tags=Mac+OS+X+10.6&created=2&created_date=03%2F20%2F2011&updated=0&updated_date=&sortby=3&a=1&w=2

and 

https://support.mozilla.com/en-US/search?q=&is_locked=0&num_voted=0&num_votes=&asked_by=&answered_by=&q_tags=Windows+7&created=2&created_date=03%2F20%2F2011&updated=0&updated_date=&sortby=3&a=1&w=2

return nothing

I expect them to return questions from those OSes.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Doing a search for the tag "Windows", brings up things tagged with "Windows", but doing a search for "Windows 7" brings up nothing.

I looked into this and what's going on is that the code is splitting the tags on white space characters. So a search for "Windows 7" creates two tag filters: one for Windows and one for 7. 

Given the directions in the Advanced Search page, I think that's wrong and it should be splitting on commas.

That's pretty easy to fix.

Sticking it in the 2012.12 milestone since I'm fiddling in that code anyhow.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a pull request: https://github.com/mozilla/kitsune/pull/681

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/kitsune/commit/6a91767078347735279c25a9d78a9205af39836d

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Oops--retroactively grabbing this one.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed to production just now.