The default bug view has changed. See this FAQ.

--enable-application should default to browser

RESOLVED FIXED in mozilla5

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ted, Assigned: Mitch)

Tracking

({dev-doc-complete})

Trunk
mozilla5
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
I mentioned this on IRC and on a mailing list, and got positive responses. We should make --enable-application default to browser, so that simply running "configure && make" from a source tarball gets you a Firefox build that's almost identical to what we ship. This is the only required configure option right now, and since 99% of people want to build Firefox, we might as well just make it easier. This makes us more in line with other open source project builds as well.

(Since client.mk defaults to an objdir, this means you could also make -f client.mk without a mozconfig and get a reasonable build of Firefox in an objdir.)
(Assignee)

Updated

6 years ago
Assignee: nobody → mitchell.field
(Assignee)

Comment 1

6 years ago
Created attachment 521749 [details] [diff] [review]
Patch
Attachment #521749 - Flags: review?(ted.mielczarek)
(Reporter)

Comment 2

6 years ago
Comment on attachment 521749 [details] [diff] [review]
Patch

Looks good, thanks!
Attachment #521749 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/projects/build-system/rev/cdd24c96c6f4
Status: NEW → ASSIGNED
Whiteboard: fixed-in-bs
Target Milestone: --- → mozilla2.2
Keywords: dev-doc-needed
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/mozilla-central/rev/cdd24c96c6f4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
I've updated:

https://developer.mozilla.org/en/Configuring_Build_Options

This has a note at the top as well as a similar one where it talks about --enable-application.

In addition, I've added information about mozilla-aurora to:

https://developer.mozilla.org/En/Developer_Guide/Source_Code/Mercurial#mozilla-aurora_(second-stage_development_tree)

Figured I'd tackle that at the same time since it's somewhat related.

In addition, this change is mentioned on Firefox 5 for developers.
Keywords: dev-doc-needed → dev-doc-complete
Does the theory that this builds something roughly the same as what we ship include building a universal 32-bit/64-bit binary on Mac?
(Reporter)

Comment 7

6 years ago
No, that doesn't. I think that's not quite as useful. Note that you don't get a PGO build by default on Windows either. Both of those options add a lot to your compile time, but don't give you much in return if you just want a build you can run locally. People trying to replicate exactly what we ship are probably a smaller group than just people trying to build Firefox that's close enough to what we ship that they can usefully hack on it.
(Reporter)

Comment 8

6 years ago
There's probably some value in an MDN document describing how to more-exactly reproduce what we ship on each platform.
Agreed. I will file a bug to put it on the future roadmap, although realistically it's something that someone in releng might be better suited to produce.
You need to log in before you can comment on or make changes to this bug.