Closed Bug 644905 Opened 9 years ago Closed 9 years ago

Set resource aliases in manifest

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: philikon, Assigned: philikon)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 2 obsolete files)

Right now we set the resource aliases programmatically in Weave.js. That made sense when we still envisioned to do fast add-on release cycles past Firefox 4. With Firefox itself doing fast release cycles, we've dropped the add-on completely, thus the need for having the add-on override them. (And even if it wanted, I believe it could still do that...)

tl;dr: rip out some baroque code I wrote when I was young and needed the money.
Attached patch WIP v1 (obsolete) — Splinter Review
I haz patch! Try build r here: http://tbpl.mozilla.org/?tree=MozillaTry&rev=5d67f1114716
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #521727 - Flags: review?(rnewman)
Attachment #521727 - Flags: feedback?(mh+mozilla)
Comment on attachment 521727 [details] [diff] [review]
WIP v1

Bah, this only seems to work superficially. resource://services-sync/ resolves, resource://services-sync/main.js does not. Retracing for now.
Attachment #521727 - Attachment description: v1 → WIP v1
Attachment #521727 - Flags: review?(rnewman)
Attachment #521727 - Flags: feedback?(mh+mozilla)
Comment on attachment 521727 [details] [diff] [review]
WIP v1

Tools menu shows both "Set up Sync" and "Sync Now". That ain't good.

Possibly related to these std{out,err} errors:

JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://browser/content/browser.js :: <TOP_LEVEL> :: line 85"  data: no]

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: file:///Volumes/HDD/build/services-central/obj-ff-dbg/dist/Minefield.app/Contents/MacOS/components/Weave.js :: <TOP_LEVEL> :: line 65"  data: no]
************************************************************

JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://browser/content/browser.js :: <TOP_LEVEL> :: line 85"  data: no]

JavaScript error: chrome://browser/content/browser.js, line 5165: Weave is not defined
JavaScript error: chrome://browser/content/browser.js, line 5165: Weave is not defined
Looks like I midair'ed you :)
Attached patch v1 (obsolete) — Splinter Review
D'oh, forgot trailing slashes. Works now!
Attachment #521727 - Attachment is obsolete: true
Attachment #521729 - Flags: review?(rnewman)
Attachment #521729 - Flags: feedback?(mh+mozilla)
Comment on attachment 521729 [details] [diff] [review]
v1

Verified with a local build, including poking around in prefs.
Attachment #521729 - Flags: review?(rnewman) → review+
Attached patch v1.1Splinter Review
Bah, I ran the services/sync/ tests but not the services/crypto/ tests. And that, Ladies and Gentlemen, is why we do try builds!

Here's v1.1 patch with fix. New try build at http://tbpl.mozilla.org/?tree=MozillaTry&rev=e7d5c1ed8bb8
Attachment #521729 - Attachment is obsolete: true
Attachment #521729 - Flags: feedback?(mh+mozilla)
Attachment #521743 - Flags: feedback?(mh+mozilla)
Attachment #521743 - Flags: feedback?(mh+mozilla)
Whiteboard: [fixed in services] → [fixed in services][qa-]
http://hg.mozilla.org/mozilla-central/rev/a04fc798eb36
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → mozilla5
Component: Firefox Sync: Build → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.