Closed Bug 644908 Opened 15 years ago Closed 15 years ago

Remove listing for the default theme from the API results

Categories

(addons.mozilla.org Graveyard :: API, defect)

Product:
addons.mozilla.org Graveyard
Component:
API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mossop, Assigned: jbalogh)

Details

So I guess a long long time ago someone uploaded a theme to AMO with the same ID as the default theme ({972ce4c6-7e08-4474-a285-3208198ce6fd}). Unfortunately the API is serving up the details for the theme in the metadata pings so anyone that goes to the details for the default theme is likely seeing the details for this other thing (http://grab.by/9FUE). The API is listing the theme as disabled by Mozilla, but since bug 638113 we accept any status as being ok. Bug 638113 comment 5 suggests that anything returned by the API should be safe but that clearly isn't the case here. I think we should not be returning disabled add-ons in the API, but if we should then I think we really need to remove the listing for this one add-on since it overrides the details for our default theme right now.
Severity: normal → critical
Severity: critical → normal
I should mention that I think this changed recently since my Firefox was seeing the real details and I had to trigger an update check to get the bad data. This suggests that the API results changed in the last day or two.
Severity: normal → critical
Assignee: nobody → jbalogh
The fix is live, leaving open for tests (hi Mossop).
Severity: critical → normal
Target Milestone: --- → 6.0.3
(In reply to comment #3) > The fix is live, leaving open for tests (hi Mossop). Tests on our end or are you saying mossop should test it?
Target Milestone: 6.0.3 → 6.0.4
(In reply to comment #4) > (In reply to comment #3) > > The fix is live, leaving open for tests (hi Mossop). > > Tests on our end or are you saying mossop should test it? I can confirm that this is fixed from my end
https://github.com/jbalogh/zamboni/commit/e09c59d Good thing I filed this bug since this fix never made it to master.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/guid:%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D returns zero results. Marking this verified based on comment 5.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.