Add Sharing UI to Firefox

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 521756 [details] [diff] [review]
v1

This adds the F1 navbar button and the File/App menu item to Firefox. It does *not* add the content area context menu item or anything else, mostly because I wanted to be conservative in what UI bits we add to Firefox (especially since the UX may easily change in the next few days).

I preemptively landed this in the project repo as https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/ee945eb938e9.

I also landed the theming bits based on the add-on: https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/ba465d64fc75. This will *definitely* change so I'm not even bothering asking for review on that one.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #521756 - Flags: review?(clarkbw)
(In reply to comment #1)
> I also landed the theming bits based on the add-on:
> https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/ba465d64fc75.
> This will *definitely* change so I'm not even bothering asking for review on
> that one.

Just landed a small follow-up to that:
https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/79d6b464a11e
Comment on attachment 521756 [details] [diff] [review]
v1

looks good.  r=clarkbw
Attachment #521756 - Flags: review?(clarkbw) → review+
Thanks, Bryan.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Depends on: 654627
You need to log in before you can comment on or make changes to this bug.