644931 - Add Sharing UI to Firefox

Status: RESOLVED FIXED

(Cloud Services :: Share: Firefox Client, defect)

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

This adds the F1 navbar button and the File/App menu item to Firefox. It does *not* add the content area context menu item or anything else, mostly because I wanted to be conservative in what UI bits we add to Firefox (especially since the UX may easily change in the next few days).

I preemptively landed this in the project repo as https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/ee945eb938e9.

I also landed the theming bits based on the add-on: https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/ba465d64fc75. This will *definitely* change so I'm not even bothering asking for review on that one.

Comment 2

[Philipp von Weitershausen [:philikon]]

(In reply to comment #1)
> I also landed the theming bits based on the add-on:
> https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/ba465d64fc75.
> This will *definitely* change so I'm not even bothering asking for review on
> that one.

Just landed a small follow-up to that:
https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/79d6b464a11e

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 521756 [details] [diff] [review]
v1

looks good.  r=clarkbw

Comment 4

[Philipp von Weitershausen [:philikon]]

Thanks, Bryan.