645055 - Put locale/ dir into SVN, use SVN checkout on stage and prod

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect, P1)

Description

[Fred Wenzel [:wenzel]]

(not a TBG bug)

The locale dir is in git at the moment. It needs to move to SVN instead (and be added to the gitignore file). Then on stage, it should be an svn checkout of that dir.

.mo files should be in SVN, how they get there (autol10n cron job or a pre/postcommit hook or something like that) is TBD.

Comment 1

[Fred Wenzel [:wenzel]]

(In reply to comment #0)
> .mo files should be in SVN, how they get there (autol10n cron job or a
> pre/postcommit hook or something like that) is TBD.

After talking to Stas, a probably preferable solution is to adapt the update_site script from Playdoh/spark[1] to update locale/ from SVN and compile the .mo files.

[1] https://github.com/mozilla/spark/blob/master/bin/update_site.py

Comment 2

[Staś Małolepszy :stas]

Once I extract the strings (which I can't right now due to bug 647352), I'll take care of creating the SVN repo and putting the PO files there.

I can also prepare a patch implementing the solution from comment 1.

Comment 3

[Staś Małolepszy :stas]

Notes to self:

- markup is not playdoh, so there's no bin/update_site.py.  will need to use a regular po-compiling cronjob.

- the locale dir needs to be git removed before the svn repo can be checked out on stage/prod.

Comment 4

[Fred Wenzel [:wenzel]]

(In reply to comment #3)
> Notes to self:
> 
> - markup is not playdoh, so there's no bin/update_site.py.  will need to use a
> regular po-compiling cronjob.

That can be remedied. update-site should still work. If you could give it a try, that'd be hot.

> - the locale dir needs to be git removed before the svn repo can be checked out
> on stage/prod.

/me nods

Comment 5

[Staś Małolepszy :stas]

(In reply to comment #4)
> (In reply to comment #3)
> > Notes to self:
> > 
> > - markup is not playdoh, so there's no bin/update_site.py.  will need to use a
> > regular po-compiling cronjob.
> 
> That can be remedied. update-site should still work. If you could give it a
> try, that'd be hot.

Let me try tomorrow, then.  I agree that it would be great to have.

Comment 6

[Fred Wenzel [:wenzel]]

(In reply to comment #3)
> - the locale dir needs to be git removed before the svn repo can be checked out
> on stage/prod.

Removed in https://github.com/mozilla/markup/commit/52c05b3 . Markup does not have a locale/ dir in git anymore now.

Comment 7

[Fred Wenzel [:wenzel]]

(In reply to comment #5)
> > That can be remedied. update-site should still work. If you could give it a
> > try, that'd be hot.
> 
> Let me try tomorrow, then.  I agree that it would be great to have.

I added the script from Spark (contains a compile-mo step) here:
https://github.com/mozilla/markup/commit/18c2261

I am not marking this bug closed because I haven't tried the script. If it works for you tomorrow, please close this bug :)

Comment 8

[Staś Małolepszy :stas]

Overdue update: I've extracted the strings into the POT file and have notified the localizers about the project.

http://svn.mozilla.org/projects/l10n-misc/trunk/markup/
https://localize.mozilla.org/projects/markup/

I'll test the Spark script now, thanks Fred.

Comment 9

[Staś Małolepszy :stas]

We're using scripts/update.sh instead of update_site.sh, but with https://github.com/mozilla/markup/commit/13983c954b4aee8630ea6cd5e2e7185bb0365dbe l10n works fine, too.

Marking this resolved.  The localized versions are up on https://markup-dev.allizom.org.