[meta] Refactor Panorama into the browser

RESOLVED WONTFIX

Status

Firefox Graveyard
Panorama
RESOLVED WONTFIX
7 years ago
2 years ago

People

(Reporter: iangilman, Unassigned)

Tracking

(Depends on: 1 bug)

Details

(Reporter)

Description

7 years ago
Obviously Panorama is part of the browser, but there are a lot of ways in which it's tacked on rather than integrated. This bug is for general discussion on this topic; we can spin individual bugs off for the various work items.

One obvious area is the tab groups data, which is currently stored in per-window sessionstore. This should be in a less ephemeral location, such as Places. This way, named groups will persist even if session isn't restored. Also, by storing them in Places (or some other centralized location), we can move to a common set of groups for all windows (see bug 578512). 

Another area is thumbnail generation and storage; rather than Panorama and Aero Peek each doing this separately, we might as well have a centralized service. This service could then be useful to other areas, such as bookmarks and history, or even for add-ons. 

Are there other areas like this? What do you think about the areas mentioned? How should we proceed?
(In reply to comment #0)
> One obvious area is the tab groups data, which is currently stored in
> per-window sessionstore. This should be in a less ephemeral location, such as
> Places.

Or tabbrowser?
Depends on: 645371
(Reporter)

Comment 2

7 years ago
(In reply to comment #1)
> (In reply to comment #0)
> > One obvious area is the tab groups data, which is currently stored in
> > per-window sessionstore. This should be in a less ephemeral location, such as
> > Places.
> 
> Or tabbrowser?

Isn't tabbrowser per window? If not, then yes, that would be a good place to manage the group data, but it still needs to be stored somewhere, like Places.
(In reply to comment #2)
> (In reply to comment #1)
> > (In reply to comment #0)
> > > One obvious area is the tab groups data, which is currently stored in
> > > per-window sessionstore. This should be in a less ephemeral location, such as
> > > Places.
> > 
> > Or tabbrowser?
> 
> Isn't tabbrowser per window? If not, then yes, that would be a good place to
> manage the group data, but it still needs to be stored somewhere, like Places.

tabbrowser is indeed per-window, but on the assumption that all tabs within a single group are from the same window (a safe assumption?) groups themselves could potentially be managed in tabbrowser. For group information across windows, indeed, something like Places or a separate JSM (like the groups.jsm of past) would be necessary, I believe.
(Reporter)

Comment 4

7 years ago
One question I raise in bug 578512 is whether we want to be able to have tabs that aren't actually attached to any window. Perhaps more of tabbrowser needs to become less window-dependent.
Blocks: 650666
Some parts, like thumbnails, have already been tackled but we're not planning to make TabGroups a core feature anytime soon.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX

Updated

5 years ago
Depends on: 865594
(Assignee)

Updated

2 years ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.