Closed Bug 64509 Opened 25 years ago Closed 25 years ago

remove nsCSSLayout.cpp and nsCanvasFrame.cpp

Categories

(Core :: Layout, defect, P4)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: dbaron, Assigned: dbaron)

Details

We should remove layout/html/style/src/nsCSSLayout.cpp. The whole file is |#if 0| and it's horribly out of date anyway.
Status: NEW → ASSIGNED
Priority: -- → P4
Target Milestone: --- → mozilla0.8
This file isn't in the windows or Unix makefiles at all. I don't think I need to post a patch since all that needs to be done is: * see if it's in the mac build -- if so, remove it * cvs remove the file Kipp removed it from the build on Windows and Unix and made it #if 0 back on 1998-10-13: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=kipp%25netscape.com&whotype=match&sortby=Date&hours=2&date=explicit&mindate=1998-10-13&maxdate=1998-10-13+13%3A43&cvsroot=%2Fcvsroot
sr=buster.
did you ever got around the check this in?
->0.9, since I still don't know whether it's in the mac project
Target Milestone: mozilla0.8 → mozilla0.9
[20:07:05] <dbaron> smfr: could you check to see if layout/html/style/src/nsCSSLayout.cpp is still in the mac project? (it's obsolete, and I want to remove it sometime) ... [20:08:09] <smfr> dbaron: it is not in the project
Ugh, it's been moved to content, so I need someone to check the mac project file again...
[20:52:48] <dbaron> Could someone check the mac project file for content and make sure nsCSSLayout.cpp isn't build, and also check the mac project file for layout and make sure that nsCanvasFrame.cpp isn't built? [20:53:18] <pinkerton> dbaron: how recently? is a tree from yesterday ok? [20:53:41] <dbaron> pinkerton: sure [20:54:23] <pinkerton> dbaron: neither are being built, from what i can see [20:54:33] <dbaron> pinkerton: ok, good.
Summary: remove nsCSSLayout.cpp → remove nsCSSLayout.cpp and nsCanvasFrame.cpp
I'd also like to remove nsCanvasFrame.cpp, which was an attempt by troy to rename nsHTMLFrame.cpp. nsHTMLFrame.cpp has continued to evolve. It wouldn't be a bad idea to rename it, but if we do we should a) start over b) copy the cvs file so we don't lose the log
sr=waterson
OK, files removed 2001-03-08 19:10 PST / 19:14 PST.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Marking verified per last comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.