645170 - Do not check in concatenated JS files

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect)

Description

[Fred Wenzel [:wenzel]]

markApp.js has over 7000 (!) LOC and is very hard to review. Keep the actual app code in there, but please put JS libraries like socialShare, and especially third-party apps like jQuery selectBox into separate files. Since all is concatenated and minified anyway, there's no reason to squeeze things into a single file, and it'll make code reuse very hard down the road.

From my guestimations, this will reduce the size of that file to 2000 LOC. That's still big, less than a third of the current size.

Comment 1

[Fred Wenzel [:wenzel]]

Argh, that's the concatenated code, isn't it?

Please add those files to a .gitignore file and don't check them in. You are free to keep the .min files in there though since those are the ones used by the app and it'd simplify deployment.

Comment 2

[Adam Miller]

Remove markApp.js from the repo.

Comment 3

[Matt Brandt [:mbrandt]]

Verified markApp.js has been removed from the repo.

Does /ffdemo/templates_orig/home.html need to be updated to reflect this?

markup mbrandt$ grep -r "markApp.js" .
Binary file ./.git/index matches
./ffdemo/templates_orig/home.html:<script src="/media/assets/js/vendor/jquery.markApp.js" type="text/javascript"></script>
host-4-30:markup

Comment 4

[Adam Miller]

You must be looking at an old version. 

https://github.com/mozilla/markup/blob/master/ffdemo/templates_orig/home.html

Comment 5

[Matt Brandt [:mbrandt]]

Thanks Adam! QA Verified.