nsACProxyListener::OnDataAvailable is broken

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
8 years ago
4 months ago

People

(Reporter: bzbarsky, Assigned: sicking)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It needs to either throw or consume the data from the stream: that's the nsIStreamListener contract.  It's current behavior causes asserts if the server responds to a preflight by sending a message with a body...

Jonas, you're reworking this code anyway, right?
OS: Mac OS X → All
Hardware: x86 → All
Posted patch Patch to fixSplinter Review
Assignee: nobody → jonas
Attachment #523156 - Flags: review?(bzbarsky)
Comment on attachment 523156 [details] [diff] [review]
Patch to fix

s/DummyStreamReaderFunc/NS_DiscardSegment/ (after including nsStreamUtils.h), and r=me
Attachment #523156 - Flags: review?(bzbarsky) → review+
Checked in. Thanks for finding this and for reviewing!

http://hg.mozilla.org/mozilla-central/rev/bc035b7a2aab
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.