645720 - Have your way with the file viewer

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Wil Clouser [:clouserw]]

Bug 632719 and bug 632721 made a file viewer for the editor tools.  Please check it out.

Old:
https://addons.allizom.org/en-US/firefox/files/browse/24393/

New:
https://addons.allizom.org/z/en-US/firefox/files/browse/24393/

Comment 1

[Axel Grude [:realRaven]]

Cool. viewing js files does not work but it looks like you paid attention to the navigation aspects. Really like the previous / next links.

For inspiration, also take a look at: Bug 597850

Comment 2

[Axel Grude [:realRaven]]

Attachment: alternative File / Diff viewer

Here is a concept drawing for an alternative version that I made in mid February when Jorge published his - for more details take a look (and please comment) at the wiki

https://wiki.mozilla.org/View_Source_Alternative

What's different 
- the link buttons are graphical and integrated in the top, support jump next difference and next different file
- Reviewer Notes integrated underneath file navigation (splitterbar!)
- button for copying current code location (file:line) which acts as bookmark from the review window
- nice to have: collapsable code and collapsable diff areas

Comment 3

[Wil Clouser [:clouserw]]

Thanks Axel.  This is a QA tracking bug, meant for QA to verify  what is currently implemented.  Please file separate enhancement bugs if you've got more ideas (and it sounds like you do! :).

Comment 4

[Wil Clouser [:clouserw]]

-> 6.0.11 to see if there is anything left to do

Comment 5

[krupa raj[:krupa]]

This is done. New bugs will be filed separately.