645746 - Diff viewer never finishes thinking

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Wil Clouser [:clouserw]]

This just spins forever:

https://addons.allizom.org/z/en-US/firefox/files/compare/108987...111874/

Comment 1

[Wil Clouser [:clouserw]]

Apparently not just the diff viewer.  https://addons.allizom.org/z/en-US/firefox/files/browse/75376/

That file is known to have UCS-2 little endian encoding (bug 628927).  Maybe that's related.

Comment 2

[Andy McKay]

That one did come through for me:

https://addons.allizom.org/z/en-US/firefox/files/browse/75376/

I'll chalk that up to celery. The diff viewer was due to an error in the log writing, awaiting an r? at the moment.

Comment 3

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/629d663d3a6020dabe3cc4980fc87f1c67f0b737

Comment 4

[Wil Clouser [:clouserw]]

The link in comment 1 still spins forever for me.  Maybe it's just me though

Comment 5

[krupa raj[:krupa]]

(In reply to comment #4)
> The link in comment 1 still spins forever for me.  Maybe it's just me though

Happens to me too. Reopening

Comment 6

[Andy McKay]

Apr  7 14:59:44 pm-gearman-amo02.mozilla.org: [None] z.task:INFO [1@None] Unzipping 108987, 111874 for file viewer. :/data/amo_python/www/preview/zamboni/apps/files/tasks.py:11
Apr  7 14:59:45 pm-gearman-amo02.mozilla.org: [None] z.task:ERROR Error ([Errno 2] No such file or directory: u'/mnt/netapp_amo/addons.mozilla.org-preview/files/12994/seo_blogger-1.0.5-fx.xpi') extracting /mnt/netapp_amo/addons.mozilla.org-preview/files/12994/seo_blogger-1.0.5-fx.xpi :/data/amo_python/www/preview/zamboni/apps/files/helpers.py:57

It gets there for me. Should I move it to a faster celery queue?

Comment 7

[Andy McKay]

I stand corrected.

Comment 8

[Andy McKay]

Working for me and krupa. Please reopen and let me know the file if it occurs again.

Comment 9

[krupa raj[:krupa]]

The page loads now even though the files we are trying to view don't seem to exist.

verified @ https://addons.allizom.org/z/en-US/firefox/files/compare/108987...111874/