configure should be permitted to disable gconf support all together

RESOLVED INVALID

Status

()

Core
Build Config
RESOLVED INVALID
7 years ago
6 years ago

People

(Reporter: Jory A. Pratt, Assigned: Jory A. Pratt)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 522420 [details] [diff] [review]
allow disabling gconf support.

Configure should not automagically add gconf support if the user does not run gnome. Gconf is only used to set the default browser which is only useful for gnome-2.x users. Attached is a patch that will permit the user to disable gconf support if they do not need/want it.
(Assignee)

Updated

7 years ago
Attachment #522420 - Flags: review?(khuey)
Attachment #522420 - Flags: review?(khuey) → review+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/038340b47ab9

I assume we don't necessary need this in 2.0 if we release 2.2 in less than 3 months now.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Version: unspecified → Trunk
(Assignee)

Comment 2

7 years ago
Created attachment 543685 [details] [diff] [review]
finish disabling gconf support if requested

Reopened until we get a solution or current patch approved.
Assignee: nobody → anarchy
Status: RESOLVED → REOPENED
Attachment #543685 - Flags: review?(khuey)
Resolution: FIXED → ---

Updated

7 years ago
Blocks: 649492
Comment on attachment 543685 [details] [diff] [review]
finish disabling gconf support if requested

This looks good ... I hope you've tested it ;-)

r=me
Attachment #543685 - Flags: review?(khuey) → review+
(Assignee)

Comment 4

7 years ago
(In reply to comment #3)
> Comment on attachment 543685 [details] [diff] [review] [review]
> finish disabling gconf support if requested
> 
> This looks good ... I hope you've tested it ;-)
> 
> r=me

I have tested it :b throughly to ensure that no instance of gconf is fired up from the browser :)
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
If you could add author & commit-message metadata to the patch, as described here...
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f
...that will help this get checked in faster (by making things easier for whoever ends up volunteering to check it in).
(Assignee)

Comment 6

7 years ago
Created attachment 544685 [details] [diff] [review]
Finish removing gconf support when requested

Carrying over review, updated summary and author as requested by Daniel
Attachment #544685 - Flags: review+
Unclear what needs to be checked in here. Please mark obsolete patches as obsolete. I assumed I should only import the third patch, but it fails to apply on mozilla-central tip.
Keywords: checkin-needed
Landed:
  http://hg.mozilla.org/integration/mozilla-inbound/rev/1f8010810cee
(first patch was landed already in comment 1, and second patch == third patch modulo commit headers.  3rd patch applies fine with fuzz, & I verified manually that the fuzz did the right thing.)
Whiteboard: [inbound]
Attachment #543685 - Attachment is obsolete: true
backed out because it was compiling only on Linux
Whiteboard: [inbound]
look like the #else in nsStaticXULComponents.cpp is serving the wrong ifdef?
Yup - the build failure is about missing SYSTEMPREF_MODULES in that file, which is what that ifdef/else area guards.
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1310113963.1310114729.14446.gz

Jory, could you fix that & rebase the patch?
(Assignee)

Comment 12

7 years ago
(In reply to comment #11)
> Yup - the build failure is about missing SYSTEMPREF_MODULES in that file,
> which is what that ifdef/else area guards.
> http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1310113963.
> 1310114729.14446.gz
> 
> Jory, could you fix that & rebase the patch?

Yeah I will fix it, be this weekend before I can get to it tho sorry for the inconvience.
(Assignee)

Comment 13

6 years ago
Work is invalid with latest trunk builds. If the need arises I will rework everything until that time closing.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.