645850 - [input-stage] Internal Server Error - OverflowError: mktime argument out of range

Status: VERIFIED FIXED

(Input :: General, defect)

Description

[Matt Brandt [:mbrandt]]

Traceback (most recent call last):

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/apps/input/decorators.py", line 127, in negotiated
    return release(request, *args, **kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/utils/decorators.py", line 76, in _wrapped_view
    response = view_func(request, *args, **kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/apps/input/decorators.py", line 43, in cached_view
    return f(request, *args, **kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/apps/search/views.py", line 278, in release
    client=c)

  File "/data/www/input.stage.mozilla.com/reporter/apps/search/views.py", line 58, in _get_results
    opinions = c.query(query, **search_opts)

  File "/data/www/input.stage.mozilla.com/reporter/apps/search/client.py", line 179, in query
    (includes, ranges, metas) = extract_filters(kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/apps/search/client.py", line 81, in extract_filters
    end = time_as_int(end_date)

  File "/data/www/input.stage.mozilla.com/reporter/apps/search/client.py", line 93, in time_as_int
    return int(timegm(t) if utc else time.mktime(t))

OverflowError: mktime argument out of range


<WSGIRequest
GET:<QueryDict: {u'product': [u'firefox'], u'version': [u'4.0'], u'date_start': [u'03/28/2080'], u'date_end': [u'']}>,
POST:<QueryDict: {}>,
COOKIES:{'WT_FPC': 'id=21b9f2b7e723785ca901301338923042:lv=1301338934458:ss=1301338923042',
 'csrftoken': 'f0d3cdefa91c0df542e4be74f24dd48a',
 'intro_seen': 'true',
 's_vi': '',
 'wtspl': '602215'},
META:{'CSRF_COOKIE': 'f0d3cdefa91c0df542e4be74f24dd48a',
 'DOCUMENT_ROOT': '/data/www/input.stage.mozilla.com',
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTP_ACCEPT': 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8',
 'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.7',
 'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
 'HTTP_ACCEPT_LANGUAGE': 'en-us,en;q=0.5',
 'HTTP_CONNECTION': 'keep-alive',
 'HTTP_COOKIE': 's_vi=[CS]v1|26A46D4805163AFD-600001820037051D[CE]; csrftoken=f0d3cdefa91c0df542e4be74f24dd48a; wtspl=602215; intro_seen=true; WT_FPC=id=21b9f2b7e723785ca901301338923042:lv=1301338934458:ss=1301338923042',
 'HTTP_HOST': 'input.stage.mozilla.com',
 'HTTP_KEEP_ALIVE': '115',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0',
 'HTTP_X_CLUSTER_CLIENT_IP': '63.245.220.240',
 'HTTP_X_FORWARDED_FOR': '63.245.220.240',
 'HTTP_X_MOZ_PLATFORM': 'other',
 'PATH_INFO': u'/en-US/release/',
 'PATH_TRANSLATED': '/data/www/input.stage.mozilla.com/reporter/wsgi/reporter.wsgi/en-US/release/',
 'QUERY_STRING': 'product=firefox&version=4.0&date_start=03%2F28%2F2080&date_end=',
 'REMOTE_ADDR': '10.2.81.103',
 'REMOTE_PORT': '54215',
 'REQUEST_METHOD': 'GET',
 'REQUEST_URI': '/en-US/release/?product=firefox&version=4.0&date_start=03%2F28%2F2080&date_end=',
 'SCRIPT_FILENAME': '/data/www/input.stage.mozilla.com/reporter/wsgi/reporter.wsgi',
 'SCRIPT_NAME': u'',
 'SERVER_ADDR': '10.2.81.29',
 'SERVER_ADMIN': '[e-mail]',
 'SERVER_NAME': 'input.stage.mozilla.com',
 'SERVER_PORT': '80',
 'SERVER_PROTOCOL': 'HTTP/1.1',
 'SERVER_SIGNATURE': '<address>Apache/2.2.3 (Red Hat) Server at input.stage.mozilla.com Port 80</address>\n',
 'SERVER_SOFTWARE': 'Apache/2.2.3 (Red Hat)',
 'mod_wsgi.application_group': 'input.stage.mozilla.com|',
 'mod_wsgi.callable_object': 'application',
 'mod_wsgi.handler_script': '',
 'mod_wsgi.input_chunked': '0',
 'mod_wsgi.listener_host': '',
 'mod_wsgi.listener_port': '80',
 'mod_wsgi.process_group': '',
 'mod_wsgi.request_handler': 'wsgi-script',
 'mod_wsgi.script_reloading': '1',
 'mod_wsgi.version': (3, 2),
 'wsgi.errors': <mod_wsgi.Log object at 0x9b46ea8>,
 'wsgi.file_wrapper': <built-in method file_wrapper of mod_wsgi.Adapter object at 0x8e88608>,
 'wsgi.input': <mod_wsgi.Input object at 0x9b46ed0>,
 'wsgi.loaded': datetime.datetime(2011, 3, 28, 14, 45, 27, 148130),
 'wsgi.multiprocess': True,
 'wsgi.multithread': False,
 'wsgi.run_once': False,
 'wsgi.url_scheme': 'http',
 'wsgi.version': (1, 1)}>

Comment 1

[Fred Wenzel [:wenzel]]

Nice! As in, wow, mktime can't do the year 2080?

Comment 2

[Fred Wenzel [:wenzel]]

It's a 32bit issue: right about in 2038, you reach 2^31, the maximum of a signed integer.

On this note: http://people.mozilla.com/~fwenzel/stage.jpg

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Bump to 4.2

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

4.2 is frozen, moving things to 4.x and will reassign to more specific milestones soon.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Bumping for now.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

WebQA has a concern that xfail'ing this will hide a potential bug, but it's also plaguing our automation tests.  What's the team's consensus on its importance?

Comment 8

[Fred Wenzel [:wenzel]]

Honestly I'd just fix it in the code and catch the overflow if it occurs. It should never legitimately be an issue, but it should also not throw a 500 error.

If we still run Input in 2038 and still have 32bit machines anywhere by then, we can start worrying then.

Comment 9

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/mozilla/input.mozilla.org/commit/0e34444

Comment 10

[Matt Brandt [:mbrandt]]

QA verified. Thanks dd

Comment 11

[Matt Brandt [:mbrandt]]

Removed the xfail on our Selenium tests. hot!

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Matt Brandt [:mbrandt] from comment #11)
> Removed the xfail on our Selenium tests. hot!

<3