Closed Bug 645883 Opened 9 years ago Closed 9 years ago

"Deactivate this device" should not default to action

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: rnewman, Assigned: emtwo)

Details

(Whiteboard: [good first bug][verified in services])

Attachments

(2 files)

I'd feel safer if "Cancel" were the default button in this dialog.
Whiteboard: [good first bug]
Assignee: nobody → msamuel
Attachment #528998 - Flags: review?(rnewman)
Attachment #528998 - Flags: review?(philipp)
Comment on attachment 528998 [details] [diff] [review]
patch for bug 645883

Philipp's on PTO today, so I'll leave this at one reviewer :D
Attachment #528998 - Flags: review?(philipp)
Comment on attachment 528998 [details] [diff] [review]
patch for bug 645883

Lovely. (Thanks for providing the screenshot -- saves me waiting for a build!)

STR for QA: click "deactivate this device", and verify that "Cancel" is the default. Please test on Windows.
Attachment #528998 - Flags: review?(rnewman) → review+
Pushed to s-c: http://hg.mozilla.org/services/services-central/rev/62317ba65526

\o/\o/\o/
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug][fixed in services]
Verified with s-c builds of 20110502
Whiteboard: [good first bug][fixed in services] → [good first bug][verified in services]
http://hg.mozilla.org/mozilla-central/rev/62317ba65526
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.