645885 - Update content script documentation for contentScriptWhen default change

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P1)

Description

[Will Bamberg [:wbamberg]]

Bug 642447 renames the 'ready' value for contentScriptWhen to 'end' and makes it the default. The documentation should be updated to reflect this.

Comment 1

[Alexandre Poirot [:ochameau]]

See bug 642447 comment 6, we didn't renamed 'ready' to 'end', but added 'end' and made it the default value.

Comment 2

[Will Bamberg [:wbamberg]]

Attachment: Update documentation for contentScriptWhen change

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 528734 [details] [diff] [review]
Update documentation for contentScriptWhen change

Review of attachment 528734 [details] [diff] [review]:

The only odd bit in my mind is that you list the options from end -> start instead of start -> end. I suppose that's due to end being default? I prefer start -> end, but it's up to you, I won't hold a review for that. r=me!

Comment 4

[Will Bamberg [:wbamberg]]

(In reply to comment #3)
> Comment on attachment 528734 [details] [diff] [review]
> Update documentation for contentScriptWhen change
> 
> Review of attachment 528734 [details] [diff] [review]:
> 
> The only odd bit in my mind is that you list the options from end -> start
> instead of start -> end. I suppose that's due to end being default? I prefer
> start -> end, but it's up to you, I won't hold a review for that. r=me!

Yeah, you're right about that. It makes more sense having them chronological, I'll make that change.

Thanks Dietrich!

Comment 5

[David Mason [:dcm :dmason]]

a=dcm for 1.0b5

Comment 6

[Will Bamberg [:wbamberg]]

Fixed by: https://github.com/mozilla/addon-sdk/commit/5e28d81a925f287a8b68702a21a9bb22c5705f8d