645899 - Updating environment groups for anything with includedtestcases fails with unsupported.environment.selection

Status: RESOLVED INVALID

(Mozilla QA :: Case Conductor-Platform, defect)

Description

[Carl Meyer (:carljm)]

Anytime I try to PUT to the /environmentgroups/ URL for a test suite or a test run that already has some includedtestcases, I get an unsupported.environment.selection error. It works fine when there have been no test cases added yet.

This is problematic for the UI, as we'd like to allow users to edit these things (environment groups and included test cases) in either order, up until the test suite or test run is activated (at which point it can't be edited anymore at all).

Comment 1

[Vadim]

The problem is that you cannot add environment groups, which are not supported by the parent Product. This means that users can adjust the environment groups by narrowing them down, but not by expanding them.

Comment 2

[Carl Meyer (:carljm)]

I'll test this again when I have a chance to verify, but I'm quite sure the environment groups I'm adding _are_ supported by the parent product. This is verified by the fact that I can PUT these very same environment groups successfully if I remove all includedtestcases first. Somehow simply the addition of the includedtestcases means I cannot even narrow environment groups for the test suite or test run.

Comment 3

[Vadim]

You're correct. Having included test cases will prevent this modification from happening (as shown in the code snippet below). This is normal behavior, because Included Test Cases inherit environments from Test run upon addition, so changes to test run will not be reflected to the test cases, which are already included....

// prevent from changing if there are any test cases included already?
if ((foundItems != null) && !foundItems.isEmpty())
{
throw new UnsupportedEnvironmentSelectionException(TestRun.class.getSimpleName() + " : " + testRunId_);
}

Comment 4

[Carl Meyer (:carljm)]

(In reply to comment #3)
> You're correct. Having included test cases will prevent this modification from
> happening (as shown in the code snippet below). This is normal behavior,
> because Included Test Cases inherit environments from Test run upon addition,
> so changes to test run will not be reflected to the test cases, which are
> already included....

Ok, thanks for the clarification. That's not ideal from the user experience standpoint, but if it's not possible to change this (and propagate the changed environments down to the included test cases), I'll modify the UI to enforce the appropriate ordering (first set environments, then add test cases/suites).