javascript strict warnings in nsTreeUtils.js

VERIFIED FIXED in mozilla0.8

Status

SeaMonkey
UI Design
P2
normal
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: Henrik Gemal, Assigned: Alec Flett)

Tracking

Trunk
mozilla0.8

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fix in hand)

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
JavaScript strict warning:
chrome://global/content/nsTreeUtils.js line 374: assignment to undeclared variab
le cmdNameLiteral

JavaScript strict warning:
chrome://global/content/nsTreeUtils.js line 376: assignment to undeclared variab
le cmdName

Comment 1

18 years ago
Created attachment 22003 [details] [diff] [review]
patch - fix strict warnings

Updated

18 years ago
Keywords: patch

Comment 2

18 years ago
cc'ing alec for sr

Updated

18 years ago
Keywords: approval

Comment 4

18 years ago
r=timeless
Keywords: approval

Comment 5

18 years ago
fix checked in.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Keywords: patch
Resolution: --- → FIXED
(Reporter)

Comment 6

18 years ago
Now I'm getting:
JavaScript error:
chrome://global/content/nsTreeUtils.js line 264: debug is not defined
(Assignee)

Comment 7

18 years ago
fixed in today's build, sorry 'bout that.
(Reporter)

Comment 8

18 years ago
todays build...:

JavaScript error:
chrome://global/content/nsTreeUtils.js line 229: menuitem has no properties
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

18 years ago
*sigh* I have a fix in my tree for this, attaching a patch.
Assignee: vishy → alecf
Status: REOPENED → NEW
(Assignee)

Comment 10

18 years ago
Created attachment 23474 [details] [diff] [review]
fix error
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: fix in hand
Target Milestone: --- → mozilla0.8
(Assignee)

Comment 12

18 years ago
checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED
(Reporter)

Comment 13

18 years ago
verified with build 20010126 on win2k
Status: RESOLVED → VERIFIED
(Reporter)

Comment 14

18 years ago
When right-clicking on a bookmark in the bookmark sidebar:

JavaScript error:
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://global/content/nsTreeUtils.js :: get_localized_string :: line 502" 
data: no]
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.