Status

Mozilla Labs Graveyard
Test Pilot
RESOLVED WONTFIX
7 years ago
2 years ago

People

(Reporter: Adam Brunner, Assigned: Jono Xia)

Tracking

Details

(Whiteboard: needs-integration)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.16) Gecko/20110319 Firefox/3.6.16
Build Identifier: 

In the file "testpilot@labs.mozilla.com/modules/feedback.js" in line 110, there is the following code:
      if (path.indexOf("feedback" > -1) || path.indexOf("happy" > -1) || path.indexOf("sad" > -1)) {

This should be
      if (path.indexOf("feedback") > -1 || path.indexOf("happy") > -1 || path.indexOf("sad") > -1) {

Please note the closing parenthesis.

This could possible lead to this exception I get every page request:
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.host]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///Users/USERNAME/Library/Application%20Support/Firefox/Profiles/viay3fgv.Firefox3.6/extensions/testpilot@labs.mozilla.com/modules/feedback.js :: FeedbackManager_isInputUrl :: line 109"  data: no]

Reproducible: Always




I use Test Pilot 1.1 under Firefox 3.6.16.
(Assignee)

Comment 1

7 years ago
Hi Adam,
Thanks for catching this!  I'm not sure how I missed it.
I applied your patch in http://hg.mozilla.org/labs/testpilot/rev/9392605bd674

Thanks again.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

7 years ago
I think we should thank all your work! ;)
(Assignee)

Comment 3

7 years ago
Created attachment 524920 [details] [diff] [review]
Patch applying Adam's change
Assignee: nobody → jdicarlo
Status: RESOLVED → REOPENED
Ever confirmed: true
Attachment #524920 - Flags: review?(mark.finkle)
Resolution: FIXED → ---
(Assignee)

Updated

7 years ago
Whiteboard: needs-integration
Attachment #524920 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 4

7 years ago
mfinkle: Is this landed?
Product: Mozilla Labs → Mozilla Labs Graveyard
decommissioned
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.