646067 - Browser no longer uses entire screen when using full screen mode from maximized window state

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[[not reading bugmail]]

It seems if I start in normal mode I get full screen dimensions.
If I start in Maximized browser mode, and click on full screen, it enters full screen mode but my browser window is back to normal size.

Comment 1

[Jim Mathies [:jimm]]

Dennis, can you post STR? Full screen transitions from normal and maximized are working fine for me.

Comment 2

[Jim Mathies [:jimm]]

(In reply to comment #1)
> Dennis, can you post STR? Full screen transitions from normal and maximized are
> working fine for me.

Ah, never mind. I can reproduce.

Comment 3

[Vykintas Vyšniauskas]

Maybe it's related: when switching from a maximized window to full screen and then back, the addon bar gets hidden under the Windows taskbar.

Comment 4

[Jim Mathies [:jimm]]

Attachment: patch

We were falling through to default due to the missing full screen handler here. That calls ShowWindow(mWnd, SW_SHOWNORMAL). This bug has been around forever but it's probably never been triggered until now. (Bug 634586 uses Show to briefly hide the window while we transition.)

Comment 5

[Chris B.]

The entire screen also flashes before switching to Full Screen mode (F11).  This didn't occur in previous builds.

Comment 6

[Jim Mathies [:jimm]]

(In reply to comment #5)
> The entire screen also flashes before switching to Full Screen mode (F11). 
> This didn't occur in previous builds.

It doesn't flash really, it hides and shows briefly. The idea was to cut down on all the tearing when the page is full of content. Going from a normal window with content to full screen was always a rather painful thing to look at, this was an attempt to fix that.

Comment 7

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/666f5ba6d256

Comment 8

[Zaggy1024]

This appears to be happening to me in Windows on the Nightly, with e10s enabled. I normally have my main Firefox window taking up the right side of my screen (by dragging the window to the right border of my screen, making it take up half the screen). When I press F11, the chrome enters fullscreen, but the content stays at its previous width until the navigation bar is done transitioning off the top of the screen, at which point it draws the content box at the expected size.