Persona is no longer an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 646373 - nsITraceableChannel.setNewListener() is unimplemented under e10s
: nsITraceableChannel.setNewListener() is unimplemented under e10s
Product: Core
Classification: Components
Component: Networking: HTTP (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Jason Duell [:jduell] (needinfo me)
: Patrick McManus [:mcmanus]
Depends on: 658939
Blocks: abp 530952
  Show dependency treegraph
Reported: 2011-03-30 01:13 PDT by Wladimir Palant
Modified: 2012-10-04 06:11 PDT (History)
7 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Add setNewListener implementation to e10s (19.16 KB, patch)
2011-03-30 12:32 PDT, Jason Duell [:jduell] (needinfo me)
honzab.moz: review+
Details | Diff | Splinter Review

Description Wladimir Palant 2011-03-30 01:13:46 PDT
nsHttpChannelChild implements nsITraceableChannel but throws NS_ERROR_NOT_IMPLEMENTED when nsITraceableChannel.setNewListener() is called (affects content scripts in Fennec 4.0 attempting to use that interface). From the look of it, there is no reason why this method doesn't work - this channel implementation has a stream listener that it will call in the usual way, no reason not to replace it.
Comment 1 Jason Duell [:jduell] (needinfo me) 2011-03-30 12:32:44 PDT
Created attachment 523086 [details] [diff] [review]
Add setNewListener implementation to e10s

Should work--it's fairly straightforward.  But e10s xpcshell test is failing.  Will look into it tomorrow.

I assume from the bug reporter's name that this is holding up Addblock Plus on fennec?
Comment 2 Wladimir Palant 2011-03-30 12:50:56 PDT
Yes, the context of this report is bug 645678. I am releasing Adblock Plus 1.3.6 on Friday, it will no longer block redirects in Fennec 4 because of this bug. The alternative would be continuing to hold up garbage collection which IMHO is worse on a mobile device.
Comment 3 Honza Bambas (:mayhemer) 2011-04-11 17:02:42 PDT
Comment on attachment 523086 [details] [diff] [review]
Add setNewListener implementation to e10s

Looks good.  I didn't test the patch.  Please figure out what is wrong with the failing test you refer.  However, if we don't break existing Firefox functionality for Firebug with this, then let's land it.

Comment 4 Jason Duell [:jduell] (needinfo me) 2011-05-24 02:42:38 PDT

This is now landed on m-c.  With a little luck it'll be in the aurora merge for FF/fennec6.

Turns out test_traceable_channel was getting bit by an unrelated issue (see bug 648878).  Commented out unneeded localPort, etc., calls and test works fine.
Comment 5 Jason Duell [:jduell] (needinfo me) 2011-05-24 02:44:47 PDT
Also needed bug 658939 for the test to work.
Comment 6 Jason Duell [:jduell] (needinfo me) 2011-05-24 02:54:40 PDT
Oh, the test changes were a separate patch:
Comment 7 Jason Duell [:jduell] (needinfo me) 2011-05-24 03:39:04 PDT
FYI mobile folks--AdblockPlus needed this, hopefully it's in aurora 6

Note You need to log in before you can comment on or make changes to this bug.