Closed
Bug 646373
Opened 14 years ago
Closed 14 years ago
nsITraceableChannel.setNewListener() is unimplemented under e10s
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
People
(Reporter: jwkbugzilla, Assigned: jduell.mcbugs)
References
Details
Attachments
(1 file)
19.16 KB,
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
nsHttpChannelChild implements nsITraceableChannel but throws NS_ERROR_NOT_IMPLEMENTED when nsITraceableChannel.setNewListener() is called (affects content scripts in Fennec 4.0 attempting to use that interface). From the look of it, there is no reason why this method doesn't work - this channel implementation has a stream listener that it will call in the usual way, no reason not to replace it.
Assignee | ||
Comment 1•14 years ago
|
||
Should work--it's fairly straightforward. But e10s xpcshell test is failing. Will look into it tomorrow.
I assume from the bug reporter's name that this is holding up Addblock Plus on fennec?
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → jduell.mcbugs
Reporter | ||
Comment 2•14 years ago
|
||
Yes, the context of this report is bug 645678. I am releasing Adblock Plus 1.3.6 on Friday, it will no longer block redirects in Fennec 4 because of this bug. The alternative would be continuing to hold up garbage collection which IMHO is worse on a mobile device.
Assignee | ||
Updated•14 years ago
|
Attachment #523086 -
Flags: review?(honzab.moz)
![]() |
||
Comment 3•14 years ago
|
||
Comment on attachment 523086 [details] [diff] [review]
Add setNewListener implementation to e10s
Looks good. I didn't test the patch. Please figure out what is wrong with the failing test you refer. However, if we don't break existing Firefox functionality for Firebug with this, then let's land it.
r=honzab
Attachment #523086 -
Flags: review?(honzab.moz) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Wladimir,
This is now landed on m-c. With a little luck it'll be in the aurora merge for FF/fennec6.
http://hg.mozilla.org/mozilla-central/rev/84e2e54efcc7
Turns out test_traceable_channel was getting bit by an unrelated issue (see bug 648878). Commented out unneeded localPort, etc., calls and test works fine.
Assignee | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•14 years ago
|
||
Oh, the test changes were a separate patch:
http://hg.mozilla.org/mozilla-central/rev/6473722292ce
Assignee | ||
Comment 7•14 years ago
|
||
FYI mobile folks--AdblockPlus needed this, hopefully it's in aurora 6
You need to log in
before you can comment on or make changes to this bug.
Description
•