64640 - movemail migration will fail if there was no mail username

Status: RESOLVED WONTFIX

(MailNews Core :: Profile Migration, defect)

Description

[(not reading, please use [e-mail] instead)]

in 4.x, you could be using movemail without a username.  but default it tries to
use $(USER), so you are not required to set it.

if you then try to migrate to 6.x, you'll fail in
nsMessengerMigrator::ProceedWithMigration(), because we'll fail to get a value
for the "mail.pop_name" pref (which is used by pop and movemail)

nsMessengerMigrator::ProceedWithMigration()
{
  char *prefvalue = nsnull;
  nsresult rv = NS_OK;
 
  if ((m_oldMailType == POP_4X_MAIL_TYPE)
#ifdef HAVE_MOVEMAIL
    || (m_oldMailType == MOVEMAIL_4X_MAIL_TYPE)
#endif /* HAVE_MOVEMAIL */
    ) {
    // if they were using pop or movemail, "mail.pop_name" must have been set
    // otherwise, they don't really have anything to migrate
    rv = m_prefs->CopyCharPref(PREF_4X_MAIL_POP_NAME, &prefvalue);
    if (NS_SUCCEEDED(rv)) {
        if (!prefvalue || (PL_strlen(prefvalue) == 0)) {
          rv = NS_ERROR_FAILURE;
        }
    }
  }

I haven't figured out if we should use $(USER) or fix the code to allow it to be
blank.

Comment 1

[Eray Ozkural]

isn't fixing the code better?

Comment 2

[(not reading, please use [e-mail] instead)]

eray, movemail is a low, low priority for me.  I have no plans to work on it.

if you want to work on it, that'd be great.

Comment 3

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 4

[Wayne Mery (:wsmwk)]

as with bug 45777...
->WONTFIX since 4.x migation has been dropped on trunk. 

If one has an overwhelming need to see this fixed on branch, please attach a patch and reopen the bug.  Also, evaluate whether the issue is a bug or an enhancement request and adjust severity accordingly.
filter bugmail for "4.xmidrop" to delete these messages.