Mozmill 1.5.x doesn't remove temporary add-ons folders

VERIFIED FIXED

Status

Testing
Mozbase
--
minor
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-1.5.3+])

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
If a Mozmill test has to be run with an add-on you can use the --addon command line option to get this add-on installed. For determining the ID Mozmill unpacks the XPI to a temporary location but fails in deleting it in the 1.5.x branch.

Now that we promote our testruns with add-ons we have to make sure to not clutter the users system with those temporary files.
(Assignee)

Comment 1

7 years ago
Created attachment 523001 [details] [diff] [review]
Patch v1

Patch with nearly no impact to Mozmill but a big jump to keep the users system clean.
Attachment #523001 - Flags: review?(jhammel)
(Assignee)

Comment 2

7 years ago
Just to note, this is a backport from Mozmill 2.

Comment 3

7 years ago
Comment on attachment 523001 [details] [diff] [review]
Patch v1

wfm
Attachment #523001 - Flags: review?(jhammel) → review+

Updated

7 years ago
Whiteboard: [mozmill-1.5.x?] → [mozmill-1.5.x+]
(Assignee)

Comment 4

7 years ago
Landed on hotfix-1.5 as:
https://github.com/mozautomation/mozmill/commit/bb5de4912698b3d46c424068088bd642440d237e
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Whiteboard: [mozmill-1.5.x+] → [mozmill-1.5.3+]
(Assignee)

Comment 5

7 years ago
Looks good with 1.5.3.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.