buildbot: remove performance builders

VERIFIED FIXED

Status

Tamarin
Tools
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Chris Peyer, Assigned: Chris Peyer)

Tracking

unspecified
x86
All
Bug Flags:
flashplayer-bug -

Details

Attachments

(1 attachment, 1 obsolete attachment)

35.66 KB, patch
Brent Baker
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Performance machines are now in the internal sandbox.  Need to be removed from playercore buildbot.
Flags: flashplayer-bug-
(Assignee)

Comment 1

7 years ago
Created attachment 523042 [details] [diff] [review]
Remove perf builders and code
Attachment #523042 - Flags: review?(brbaker)

Comment 2

7 years ago
Comment on attachment 523042 [details] [diff] [review]
Remove perf builders and code

r- for a single missing item, assume r+ when addressed

1) need to update public_html/announce.html to remove the "performance" section since these builders are going to be removed.
Attachment #523042 - Flags: review?(brbaker) → review-

Comment 3

7 years ago
Additional work items that I think need to be addressed:

- link/visibility to performance waterfall from the current waterfall view
- does the "buildbot watcher performance" service need to be running on playercore? If not uninstall the service and remove performance watcher config file
- should build/buildbot/*-performance/buildbot.tac be removed from source or updated?
(Assignee)

Comment 4

7 years ago
Created attachment 523144 [details] [diff] [review]
Updated patch

- public_html/announce.html updated with a link to internal sandbox
- buildbot watcher perf service has been removed from playercore
- buildbot.tac files updated
Attachment #523042 - Attachment is obsolete: true
Attachment #523144 - Flags: review?(brbaker)

Updated

7 years ago
Attachment #523144 - Attachment is patch: true
Attachment #523144 - Attachment mime type: application/octet-stream → text/plain

Comment 5

7 years ago
Comment on attachment 523144 [details] [diff] [review]
Updated patch

r+ but please make sure to maintain and add the proper license header in the buildbot.tac files (patch shows header being removed and some of the new files do not have the header)
Attachment #523144 - Flags: review?(brbaker) → review+

Comment 6

7 years ago
changeset: 6216:faef081aaecf
user:      Chris Peyer <cpeyer@adobe.com>
summary:   Bug 646522: remove performance builders (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/faef081aaecf
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.