646595 - [rtl] Add RTL support to about:firstrun in Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anas Husseini [:linostar]]

The firstrun page needs some tweaks in order to be displayed properly on rtl fennec.

Comment 1

[Anas Husseini [:linostar]]

Attachment: patch for RTL-izing about:firstrun

I wasn't sure if I should include the flipped arrow image (nav-arrow-rtl.png) in the patch or if I had to attach the image separately. I've done the first option.

Comment 2

[Anas Husseini [:linostar]]

Attachment: patch for RTL-izing about:firstrun (image included)

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Created attachment 523246 [details] [diff] [review]
> patch for RTL-izing about:firstrun
> 
> I wasn't sure if I should include the flipped arrow image (nav-arrow-rtl.png)
> in the patch or if I had to attach the image separately. I've done the first
> option.

Adding image in the patch is fine, you can also provide an image of the final result as an attachment (sometimes people provide an image before and after the patch) so it is easy to see what the images looks like if you have many.


Looking at your patch I'm wondering if we can't avoid the cost of adding an extra image by adding an <img src="chrome://browser/content/firstrun/nav-arrow.png"/> directly in the html, align it properly and use the -moz-transform css rules to rotate it?

Can you try that?

Comment 4

[Anas Husseini [:linostar]]

Attachment: screenshot for firstrun page before the patch

Comment 5

[Anas Husseini [:linostar]]

Attachment: screenshot for firstrun page after the patch

Comment 6

[Anas Husseini [:linostar]]

Attachment: patch v2

Comment 7

[Anas Husseini [:linostar]]

BTW,tested the patch on an en-US Fennec, and it didn't break the firstrun page.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 523278 [details] [diff] [review]
patch v2

Looks good. Thanks for the patch Anas.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/bfd90c18b939

Comment 10

[Andreea Pod]

Attachment: firstrun

Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre) Gecko/20110331 Firefox/4.2a1pre Fennec /4.1a1pre 
Device: HTC Desire

This is how it looks for me. Is it ok? Can I mark this bug as verified?

Comment 11

[Anas Husseini [:linostar]]

Looks fine. Go ahead and mark it as verified.

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

verified:
Mozilla/5.0 (Android; Linux armv71; rv2.2a1pre) Gecko/20110405 Firefox/4.2a1pre Fennec/4.1a1pre
Device: Droid 2 
OS: Android 2.2