Closed Bug 646595 Opened 9 years ago Closed 9 years ago

[rtl] Add RTL support to about:firstrun in Fennec

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: linostar, Assigned: linostar)

Details

(Keywords: rtl)

Attachments

(4 files, 2 obsolete files)

The firstrun page needs some tweaks in order to be displayed properly on rtl fennec.
Assignee: nobody → linux.anas
Status: NEW → ASSIGNED
Keywords: rtl
I wasn't sure if I should include the flipped arrow image (nav-arrow-rtl.png) in the patch or if I had to attach the image separately. I've done the first option.
Attachment #523246 - Attachment is obsolete: true
(In reply to comment #1)
> Created attachment 523246 [details] [diff] [review]
> patch for RTL-izing about:firstrun
> 
> I wasn't sure if I should include the flipped arrow image (nav-arrow-rtl.png)
> in the patch or if I had to attach the image separately. I've done the first
> option.

Adding image in the patch is fine, you can also provide an image of the final result as an attachment (sometimes people provide an image before and after the patch) so it is easy to see what the images looks like if you have many.


Looking at your patch I'm wondering if we can't avoid the cost of adding an extra image by adding an <img src="chrome://browser/content/firstrun/nav-arrow.png"/> directly in the html, align it properly and use the -moz-transform css rules to rotate it?

Can you try that?
Attached patch patch v2Splinter Review
Attachment #523247 - Attachment is obsolete: true
Attachment #523247 - Flags: review?(21)
Attachment #523278 - Flags: review?(21)
BTW,tested the patch on an en-US Fennec, and it didn't break the firstrun page.
Comment on attachment 523278 [details] [diff] [review]
patch v2

Looks good. Thanks for the patch Anas.
Attachment #523278 - Flags: review?(21) → review+
Attached image firstrun
Mozilla /5.0 (Android;Linux armv7l;rv:2.2a1pre) Gecko/20110331 Firefox/4.2a1pre Fennec /4.1a1pre 
Device: HTC Desire

This is how it looks for me. Is it ok? Can I mark this bug as verified?
Looks fine. Go ahead and mark it as verified.
verified:
Mozilla/5.0 (Android; Linux armv71; rv2.2a1pre) Gecko/20110405 Firefox/4.2a1pre Fennec/4.1a1pre
Device: Droid 2 
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.