Remove obsolete comment from security/nss/lib/freebl/sha512.c

RESOLVED FIXED in 3.12.10

Status

NSS
Libraries
P2
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Mark Mentovai, Assigned: Mark Mentovai)

Tracking

3.12.3
3.12.10

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 523101 [details] [diff] [review]
Remove obsolete comment

Since bug 431958, security/nss/lib/freebl/sha512.c uses inline assembly for byte-swapping on x86 and x86-64 when being built by GCC. The #else comment in this block referring to "windows [and] Linux PC" is obsolete. The C code in the #else block will now be used when MSVC intrinsics and CPU-specific MSVC or GCC inline assembly aren’t available. This determination is less OS-biased than it had been in the past, and the comment should be removed.
(Assignee)

Updated

7 years ago
Attachment #523101 - Flags: review?(wtc)
(Assignee)

Updated

7 years ago
Attachment #523101 - Attachment is patch: true
Attachment #523101 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Updated

7 years ago
Assignee: nobody → mark
Status: NEW → ASSIGNED

Comment 1

7 years ago
Comment on attachment 523101 [details] [diff] [review]
Remove obsolete comment

r=wtc.

Patch checked in on the NSS trunk (NSS 3.13) and NSS_3_12_BRANCH
(NSS 3.12.10).

Checking in sha512.c;
/cvsroot/mozilla/security/nss/lib/freebl/sha512.c,v  <--  sha512.c
new revision: 1.18; previous revision: 1.17
done

Checking in sha512.c;
/cvsroot/mozilla/security/nss/lib/freebl/sha512.c,v  <--  sha512.c
new revision: 1.14.6.2; previous revision: 1.14.6.1
done
Attachment #523101 - Flags: review?(wtc) → review+

Comment 2

7 years ago
The defined(LINUX) to defined(__GNUC__) change was made to sha512.c
in rev. 1.13 in NSS 3.12.3.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Priority: -- → P2
Resolution: --- → FIXED
Target Milestone: --- → 3.12.10
Version: trunk → 3.12.3
You need to log in before you can comment on or make changes to this bug.