64666 - In prlog.c, assumptions about sscanf are not true for all compilers

Status: VERIFIED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Mike Kaply [:mkaply]]

We actually spoke to our compiler vendor about this.

According to them, sscanf with [A-Z] or [a-z] or [0-9] to specify ranges is not 
part of any spec.

It is just something that some compiler vendors invented as a short cut.

I looked at K&R and they make no mention that this is legal.

Anyway, the proper syntax (although ugly) is to spell it out.

I'll attach a diff

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Spell out characters rather than using ranges

Comment 2

[Wan-Teh Chang]

You are right.  I verified this is true.

I checked in your patch on the tip and NSPRPUB_CLIENT_BRANCH.

Comment 3

[Mike Kaply [:mkaply]]

Can we close this?

I believe the fix is checked in everywhere.

Comment 4

[Mike Kaply [:mkaply]]

Fix is checked in

Comment 5

[Mike Kaply [:mkaply]]

Verify fixed

Comment 6

[Wan-Teh Chang]

Set target milestone NSPR 4.2.  This fix was not checked in
on the NSPRPUB_RELEASE_4_1_BRANCH.