fp::pc should work on frames outside the current context

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
fp::pc currently only works on frames pushed by stack segments associated with the current context.  When recompiling in the JM+TI branch, we need to recompile and expand inline frames that can be on another context, but in the same compartment and StackSpace.

This requires fp::pc to walk all stack segments in the space.  Currently this would mean looking at every single frame in the thread, but it would be faster to just look at the start/end frames of each segment (since segments are continuous in memory).  This should be fixed too.
(Assignee)

Comment 1

7 years ago
Created attachment 523172 [details] [diff] [review]
patch

Patch per the above.  This is a diff against JM, but will be the same on TM except for the Retcon.cpp change.  (Will push to JM before TM, to verify this fixes crashes seen on the JM tinderbox).
Assignee: general → bhackett1024
Attachment #523172 - Flags: review?(luke)

Comment 2

7 years ago
Comment on attachment 523172 [details] [diff] [review]
patch

Great.  I forgot about StackSpace::contains :)
Attachment #523172 - Flags: review?(luke) → review+

Comment 3

6 years ago
Would you like me to land this?
(Assignee)

Comment 4

6 years ago
Sorry, been meaning to land this but got sidetracked.  There haven't been anymore problems with fp::pc on the JM branch, so feel free to land if you don't mind.  Thanks!

Comment 5

6 years ago
http://hg.mozilla.org/tracemonkey/rev/3dc5d38ba870
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/3dc5d38ba870
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.