646770 - zoom-in command key combination doesn't work for japanese keyboards

Status: RESOLVED INVALID

(Firefox :: Keyboard Navigation, defect)

Description

[John Daggett (:jtd)]

Using the English localization of FF4 with a Japanese keyboard, the zoom-in key combination doesn't function correctly.  

Steps (requires a Japanese keyboard):

1. Open a page in an English build of FF4
2. Enter Cmd-+ (i.e. <command>, <shift>, <;/+> keys together)

Expected result: zoom-in
Result: nothing happens

With either Safari or Chrome (English) this zooms in.  Ditto for Firefox 3.6en.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0) Gecko/20100101 Firefox/4.0

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

John-san, are you sure? I can reproduce that with neither latest trunk nor Fx4.0.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> data:text/html,<p%20id="p"></p><script>function%20log(event)%20{%20var%20p%20=%20document.getElementById("p");%20p.innerHTML%20=%20event.type%20+%20"%20keyCode="%20+%20event.keyCode%20+%20"%20(0x"%20+%20event.keyCode.toString(16)%20+%20"),%20charCode="%20+%20event.charCode%20+%20"%20(0x"%20+%20event.charCode.toString(16)%20+%20"),%20shift="%20+%20event.shiftKey%20+%20",ctrl="%20+%20event.ctrlKey%20+%20",%20alt="%20+%20event.altKey%20+%20",%20meta="%20+%20event.metaKey%20+%20"<BR>"%20+%20p.innerHTML;%20}%20window.addEventListener("keydown",%20log,%20false);%20window.addEventListener("keypress",%20log,%20false);%20window.addEventListener("keyup",%20log,%20false);</script>

You can check what keyCode/charCode is generated by the ';/+' key by this URL. The charCode must be 0x2b when you press Ctrl+Shift+; on Japanese keyboard with Japanese keyboard layout (Kotoeri's Eiji mode).

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Or if an add-on used Cmd+Shift+; for a shortcut key, it had higher priority than Cmd++.

Comment 4

[John Daggett (:jtd)]

Ok, this appears to be Firebug, which maps Cmd-Shift-+/- to increase/decrease the text size in the Firebug window.  This works for English keyboards (+ is lowercase) but not for Japanese keyboards (+ is uppercase so the shift key is used to enter Cmd-+).