Closed Bug 646792 Opened 9 years ago Closed 9 years ago

Let the "Learn More" link from the plugin-crashed notification from Bug 601493 point to in-app Help

Categories

(SeaMonkey :: Help Documentation, defect)

defect
Not set

Tracking

(blocking-seamonkey2.1 final+)

VERIFIED FIXED
seamonkey2.1final
Tracking Status
blocking-seamonkey2.1 --- final+

People

(Reporter: philip.chee, Assigned: InvisibleSmiley)

References

Details

Attachments

(1 file)

Bug 601493 added a "Learn More" link to the plugin-crashed UI:

>+            // Add the "learn more" link.
>+            // XXXRatty We have a 404 at http://www.seamonkey-project.org/doc/plugin-crashed
>+            // Or should we link to our in app help?
....
>+            var url = this._urlFormatter.formatURLPref("app.support.baseURL");
>+            this.crashReportHelpURL = url + "plugin-crashed";

The Firefox version of Learn More links to (after a bit of redirection):
<http://support.mozilla.com/en-US/kb/Plugin crash reports?as=u>
We can probably adapt the information from that page.

Also see Bug 646788 for in-app help.
We might want the Learn More link to take us to in-app help first, and then possibly link from there to other documents.
FTR, the source code lines from comment 0 were actually checked in and are now part of suite/common/bindings/notification.xml, so we need not only create the web page but also remove those lines from the source.
Moving to seamonkey-project.org since that is more accurate for this bug.
blocking-seamonkey2.1: --- → final+
Component: Project Organization → www.seamonkey-project.org
Product: SeaMonkey → Websites
QA Contact: organization → www-seamonkey-project-org
Version: Trunk → unspecified
I also did a trick of bugzilla to set blocking+ with my last change, even though it doesn't give UI for the flag in its current product/component.
Cf. bug 646788 comment 2. Let's discuss either there or in m.d.a.seamonkey.
(In reply to comment #5)
> Cf. bug 646788 comment 2. Let's discuss either there or in m.d.a.seamonkey.

Jens, I cheated and marked this blocking, no UI in this bug to remove blocking (but I can cheat and fix that), do you feel we need this blocking still... I don't recall a thread ever starting on this.

I'll note based on c#0 that we don't actually have this link in 2.1 atm
(In reply to comment #6)
> do you feel we need this blocking still...

I think we should really get rid of the Learn More -> website link connection and call openHelpPage in both cases instead (which goes to the in-app Help page that is still to be written). That part should be blocking so that we don't ship any release version that contains a link to a website for this functionality (i.e. now is the best chance to never get into trouble over this!). We can use this bug for that and move it out of Product Website, or close this one and open a new one. Your call.

> I'll note based on c#0 that we don't actually have this link in 2.1 atm

Wrong, we currently have both a link to the website and a link to in-app Help, and neither exists. The reason for that was that Ratty got confused, cf. bug 601493 comment 39.
Until then, here's a patch (which I couldn't really test myself since I'm building without crash reporter which you need to get the Learn More link; maybe Ratty can?):
http://pastebin.mozilla.org/1218488
(In reply to comment #7)
> (In reply to comment #6)
> > do you feel we need this blocking still...
> 
> I think we should really get rid of the Learn More -> website link connection
> and call openHelpPage in both cases instead (which goes to the in-app Help page
> that is still to be written). That part should be blocking so that we don't
> ship any release version that contains a link to a website for this
> functionality (i.e. now is the best chance to never get into trouble over
> this!). We can use this bug for that and move it out of Product Website, or
> close this one and open a new one. Your call.

Moving bug out, sounds good.

(In reply to comment #8)
> Until then, here's a patch (which I couldn't really test myself since I'm
> building without crash reporter which you need to get the Learn More link;
> maybe Ratty can?):
> http://pastebin.mozilla.org/1218488

rs+=me, land it.
Component: www.seamonkey-project.org → Help
Product: Websites → SeaMonkey
QA Contact: www-seamonkey-project-org → help
Assignee: nobody → jh
Status: NEW → ASSIGNED
Summary: Add a landing page for the "Learn More" link from the plugin-crashed notification from Bug 601493. → Let the "Learn More" link from the plugin-crashed notification from Bug 601493 point to in-app Help
Version: unspecified → Trunk
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1final
Comment on attachment 530440 [details] [diff] [review]
patch [Checkin: comment 11]

Post-landing review. Works fine. Tested by crashing the plugin-container with the Windows task manager.
Attachment #530440 - Flags: review+
Verified as per comment 12.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.