646792 - Let the "Learn More" link from the plugin-crashed notification from Bug 601493 point to in-app Help

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Philip Chee]

Bug 601493 added a "Learn More" link to the plugin-crashed UI:

>+            // Add the "learn more" link.
>+            // XXXRatty We have a 404 at http://www.seamonkey-project.org/doc/plugin-crashed
>+            // Or should we link to our in app help?
....
>+            var url = this._urlFormatter.formatURLPref("app.support.baseURL");
>+            this.crashReportHelpURL = url + "plugin-crashed";

The Firefox version of Learn More links to (after a bit of redirection):
<http://support.mozilla.com/en-US/kb/Plugin crash reports?as=u>
We can probably adapt the information from that page.

Also see Bug 646788 for in-app help.

Comment 1

[[e-mail]]

We might want the Learn More link to take us to in-app help first, and then possibly link from there to other documents.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

FTR, the source code lines from comment 0 were actually checked in and are now part of suite/common/bindings/notification.xml, so we need not only create the web page but also remove those lines from the source.

Comment 3

[Justin Wood (:Callek)]

Moving to seamonkey-project.org since that is more accurate for this bug.

Comment 4

[Justin Wood (:Callek)]

I also did a trick of bugzilla to set blocking+ with my last change, even though it doesn't give UI for the flag in its current product/component.

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Cf. bug 646788 comment 2. Let's discuss either there or in m.d.a.seamonkey.

Comment 6

[Justin Wood (:Callek)]

(In reply to comment #5)
> Cf. bug 646788 comment 2. Let's discuss either there or in m.d.a.seamonkey.

Jens, I cheated and marked this blocking, no UI in this bug to remove blocking (but I can cheat and fix that), do you feel we need this blocking still... I don't recall a thread ever starting on this.

I'll note based on c#0 that we don't actually have this link in 2.1 atm

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #6)
> do you feel we need this blocking still...

I think we should really get rid of the Learn More -> website link connection and call openHelpPage in both cases instead (which goes to the in-app Help page that is still to be written). That part should be blocking so that we don't ship any release version that contains a link to a website for this functionality (i.e. now is the best chance to never get into trouble over this!). We can use this bug for that and move it out of Product Website, or close this one and open a new one. Your call.

> I'll note based on c#0 that we don't actually have this link in 2.1 atm

Wrong, we currently have both a link to the website and a link to in-app Help, and neither exists. The reason for that was that Ratty got confused, cf. bug 601493 comment 39.

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

Until then, here's a patch (which I couldn't really test myself since I'm building without crash reporter which you need to get the Learn More link; maybe Ratty can?):
http://pastebin.mozilla.org/1218488

Comment 9

[Justin Wood (:Callek)]

(In reply to comment #7)
> (In reply to comment #6)
> > do you feel we need this blocking still...
> 
> I think we should really get rid of the Learn More -> website link connection
> and call openHelpPage in both cases instead (which goes to the in-app Help page
> that is still to be written). That part should be blocking so that we don't
> ship any release version that contains a link to a website for this
> functionality (i.e. now is the best chance to never get into trouble over
> this!). We can use this bug for that and move it out of Product Website, or
> close this one and open a new one. Your call.

Moving bug out, sounds good.

(In reply to comment #8)
> Until then, here's a patch (which I couldn't really test myself since I'm
> building without crash reporter which you need to get the Learn More link;
> maybe Ratty can?):
> http://pastebin.mozilla.org/1218488

rs+=me, land it.

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: comment 11]

Comment 11

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 530440 [details] [diff] [review]
patch [Checkin: comment 11]

http://hg.mozilla.org/comm-central/rev/0f03867fe8ed
http://hg.mozilla.org/releases/comm-2.0/rev/1f19ab8f7362

Comment 12

[Philip Chee]

Comment on attachment 530440 [details] [diff] [review]
patch [Checkin: comment 11]

Post-landing review. Works fine. Tested by crashing the plugin-container with the Windows task manager.

Comment 13

[Jens Hatlak (:InvisibleSmiley)]

Verified as per comment 12.