64713 - GCC 2.95.2 cant use -MDupdate and -lC

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Donnie Cranford]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; SunOS 5.8 i86pc; en-US; m18) Gecko/20010108
BuildID:    0000000000000000

When compiling PSM it fails using GCC 2.95.2 on Solaris for 2 reasons

1. The use of -MDupdate (Changed env var to NO_MDUPDATE=1) and it worked.

2. The linker flag -lC (pointed out by wtc) does nto work in solaris using GCC
I changed this in the security/psm/server/Makefile to -lstdc++ and it worked fine.

Once these changes are made either through ifdefs or configure PSM on Solaris
will build just fine.

Reproducible: Always
Steps to Reproduce:
1. gmake -f client.mk BUILD_MODULES=psm

Actual Results:  you get a gcc error message about using Multiple compilations
hence (-MDupdate)

and for the -lC you get an ld error saying that -lC isnt defined.



Expected Results:  it should compile PSM cleanly.

Comment 1

[Wan-Teh Chang]

Reassigned to javi.

Comment 2

[Javier Delgadillo]

Is there a patch for this?

Comment 3

[Margaret Chan]

Javier:

My patch in 67742 (for ../mozilla/security/psm/server/Makefile) addresses 
the -lC problem that's mentioned in this bug.  -lC/-lCrun is used for 
Sun's compiler while -lstdc++ is for gcc compilation.  I have put in ifdef 
in the patch for 67742 to satisfy the compilation for both compilers.
I just need approval to check in for that file.  Can you/ddrinan approve
that checkin please?  We have been patching that in our Solaris build
for quite some time now.  If neither one of you can approve for the
checkin of the coreconf files, I'll open another NSS bug for that and get
approval to checkin for those 2 files.  Please let me know
if you rather have me do that.   I want to have it checked in
instead of patching it in every build.  As for NO_MDUPDATE, I thought that
we always have to set it to 1 in the environment before the build.
Are we saying that we should set -MDupdate somewhere instead?

Comment 4

[Javier Delgadillo]

The appropriate patch has been checked into psm/server/Makefile

Comment 5

[John Unruh]

Verified per javi's comments.

Comment 6

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 7

[John Unruh]

Mass changing Security:Crypto to PSM