[ar] Adding twitter to Fennec search plugins

RESOLVED FIXED

Status

Mozilla Localizations
ar / Arabic
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: linostar, Assigned: linostar)

Tracking

({productization})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [l10n-src-verifcation needs update])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
We'd like to add twitter to fennec searchplugins (both on mobile-2.0 and mobile-browser). I took the chance to clean the old unneeded plugins (like yahoo, answers and wikipedia, but wasn't sure about google since it was removed from 1.9.2).
(Assignee)

Comment 1

7 years ago
Created attachment 523557 [details] [diff] [review]
patch adding twitter, and removing answers, yahoo and wikipedia

The patch is requested for both releases/l10n-mozilla-2.0/ar and l10n-central/ar.
Assignee: nobody → linux.anas
Status: NEW → ASSIGNED
Attachment #523557 - Flags: review?
Keywords: productization
Comment on attachment 523557 [details] [diff] [review]
patch adding twitter, and removing answers, yahoo and wikipedia

Thanks for the patch.  Good call on removing the unused search plugins.  Adding Twitter is no problem as well, but I'm gonna r- this patch because I'd like to ask you to attach a new one -- without the twitter.xml file.  Putting "twitter" in list.txt is enough.  The xml file will be copied from en-US during the build process.  Thanks!
Attachment #523557 - Flags: review? → review-

Comment 3

7 years ago
Also remove the google.xml one? You should only have wikipedia-ar.xml and list.txt in there, the other plugins are picked up from the en-US sources either way.
(Assignee)

Comment 4

7 years ago
Created attachment 523564 [details] [diff] [review]
patch v2
Attachment #523557 - Attachment is obsolete: true
Attachment #523564 - Flags: review?(stas)

Comment 5

7 years ago
Comment on attachment 523564 [details] [diff] [review]
patch v2

r=me for l10n-central and l10n-mozilla-2.0.

Please land with a check-in comment referencing this bug and my review.

Notes: stas is OK to add the search plugin on 4.0.1.
Attachment #523564 - Flags: review?(stas) → review+

Updated

7 years ago
Whiteboard: [l10n-src-verifcation needs update]
(Assignee)

Comment 6

7 years ago
Landed in

l10n-mozilla-2.0/ar:
http://hg.mozilla.org/releases/l10n-mozilla-2.0/ar/rev/321c8223aaea

l10n-central/ar:
http://hg.mozilla.org/l10n-central/ar/rev/c8e9ab5c3526
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.