647239 - [traceback] UnicodeDecodeError when reviewing some add-ons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P1)

Description

[Wil Clouser [:clouserw]]

Sorry for the late in the milestone bug, but it looks like we got a bunch of these tracebacks this morning.  Eg. /ja/editors/review/770980



File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/prod/zamboni/apps/amo/decorators.py", line 22, in wrapper
   return func(request, *args, **kw)

 File "/data/amo_python/www/prod/zamboni/apps/editors/views.py", line 36, in wrapper
   return func(request, *args, **kw)

 File "/data/amo_python/www/prod/zamboni/apps/editors/views.py", line 274, in review
   return jingo.render(request, 'editors/review.html', ctx)

 File "/data/amo_python/www/prod/zamboni/vendor/src/jingo/jingo/__init__.py", line 78, in render
   rendered = render_to_string(request, template, context)

 File "/data/amo_python/www/prod/zamboni/vendor/src/jingo/jingo/__init__.py", line 96, in render_to_string
   return template.render(**get_context())

 File "/usr/lib/python2.6/site-packages/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/amo_python/www/prod/zamboni/apps/editors/templates/editors/review.html", line 1, in top-level template code
   {% extends "editors/base.html" %}

 File "/data/amo_python/www/prod/zamboni/apps/editors/templates/editors/base.html", line 1, in top-level template code
   {% extends "base.html" %}

 File "/data/amo_python/www/prod/zamboni/templates/base.html", line 99, in top-level template code
   {% block main_content %}

 File "/data/amo_python/www/prod/zamboni/templates/base.html", line 104, in block "main_content"
   {% block content %}{% endblock %}

 File "/data/amo_python/www/prod/zamboni/apps/editors/templates/editors/review.html", line 134, in block "content"
   {% for pk, label in form.fields.get('addon_files').choices %}

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/forms/models.py", line 881, in __iter__
   yield self.choice(obj)

 File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/forms/models.py", line 887, in choice
   return (self.field.prepare_value(obj), self.field.label_from_instance(obj))

 File "/data/amo_python/www/prod/zamboni/apps/editors/forms.py", line 193, in label_from_instance
   file_review_status(addon, addon_file)))

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe3 in position 8: ordinal not in range(128)

Comment 1

[Jeff Balogh (:jbalogh)]

I have no databases where I can reproduce this at the moment, but I committed https://github.com/jbalogh/zamboni/commit/7c4326f because using _lazy is wrong there. Maybe that will take care of it.

Comment 2

[krupa raj[:krupa]]

I can reproduce this traceback @ https://addons.allizom.org/ja/editors/review/756876?num=6

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to comment #2)
> I can reproduce this traceback @
> https://addons.allizom.org/ja/editors/review/756876?num=6

Please change the milestone if you're reopening old bugs.

Comment 4

[Jeff Balogh (:jbalogh)]

https://github.com/jbalogh/zamboni/commit/414f18e

Comment 5

[krupa raj[:krupa]]

verified @ 
https://addons-next.allizom.org/en-US/editors/review/756876?num=6
https://addons-next.allizom.org/ja/editors/review/756876?num=6