Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Tracking

(Blocks 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cleanup])

Attachments

(1 attachment, 2 obsolete attachments)

Now that non-libxul builds are unsupported, my understanding is that nsIContentUtils doesn't serve a useful purpose and can be removed.
And nsIContentUtils2, and maybe nsIContentUtils3 if we managed to grow that ...

But yes, as long as the interface was only to allow it to be used cross-module (and there are no script consumers) you can scrap it.
Posted patch Patch v1 (obsolete) — Splinter Review
How does this look to you, Jonas?
Attachment #525222 - Flags: review?(jonas)
Assignee: nobody → justin.lebar+bug
Posted patch Patch v2 (obsolete) — Splinter Review
Unbitrotting after removal of a MOZILLA_2_0 interface.
Attachment #525593 - Flags: review?(jonas)
Attachment #525222 - Attachment is obsolete: true
Attachment #525222 - Flags: review?(jonas)
Posted patch Patch v3Splinter Review
Removing nsLayoutModule entries, which I initially missed.
Attachment #525614 - Flags: review?(jonas)
Attachment #525593 - Attachment is obsolete: true
Attachment #525593 - Flags: review?(jonas)
So the problem is TestChromeMargin.cpp, a Windows only cpp test.  It tests a function in ns{I}ContentUtils.

If you include nsContentUtils.h directly, you end up including enough of the world that you need to be in the internal API world.  But I can't figure out how to get this unit test into that world.  Apparently you can't just #define MOZILLA_INTERNAL_API and expect things to work.  :)

jimm or someone else: Any ideas on how to fix this?  I'd really hate to hold this bug up on a test technicality.
On IRC, jimm gave me r+ to disable widget/tests/TestChromeMargin.cpp.  I'll file a followup bug to fix and re-enable the test.
Blocks: 652123
Pushed with misbehaving test disabled: http://hg.mozilla.org/mozilla-central/rev/863db843fde4
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.