Status

()

Core
Document Navigation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cleanup])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Now that non-libxul builds are unsupported, my understanding is that nsIContentUtils doesn't serve a useful purpose and can be removed.
And nsIContentUtils2, and maybe nsIContentUtils3 if we managed to grow that ...

But yes, as long as the interface was only to allow it to be used cross-module (and there are no script consumers) you can scrap it.
(Assignee)

Comment 2

6 years ago
Created attachment 525222 [details] [diff] [review]
Patch v1

How does this look to you, Jonas?
Attachment #525222 - Flags: review?(jonas)
(Assignee)

Updated

6 years ago
Assignee: nobody → justin.lebar+bug
(Assignee)

Comment 3

6 years ago
Created attachment 525593 [details] [diff] [review]
Patch v2

Unbitrotting after removal of a MOZILLA_2_0 interface.
Attachment #525593 - Flags: review?(jonas)
(Assignee)

Updated

6 years ago
Attachment #525222 - Attachment is obsolete: true
Attachment #525222 - Flags: review?(jonas)
(Assignee)

Comment 4

6 years ago
Created attachment 525614 [details] [diff] [review]
Patch v3

Removing nsLayoutModule entries, which I initially missed.
Attachment #525614 - Flags: review?(jonas)
(Assignee)

Updated

6 years ago
Attachment #525593 - Attachment is obsolete: true
Attachment #525593 - Flags: review?(jonas)
Attachment #525614 - Flags: review?(jonas) → review+
This landed:

http://hg.mozilla.org/mozilla-central/rev/457757151653

and broke Windows builds:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1302810160.1302813617.29925.gz

and got backed out as a result:

http://hg.mozilla.org/mozilla-central/rev/026fc72b77aa
(Assignee)

Comment 6

6 years ago
So the problem is TestChromeMargin.cpp, a Windows only cpp test.  It tests a function in ns{I}ContentUtils.

If you include nsContentUtils.h directly, you end up including enough of the world that you need to be in the internal API world.  But I can't figure out how to get this unit test into that world.  Apparently you can't just #define MOZILLA_INTERNAL_API and expect things to work.  :)

jimm or someone else: Any ideas on how to fix this?  I'd really hate to hold this bug up on a test technicality.
(Assignee)

Comment 7

6 years ago
On IRC, jimm gave me r+ to disable widget/tests/TestChromeMargin.cpp.  I'll file a followup bug to fix and re-enable the test.
(Assignee)

Updated

6 years ago
Blocks: 652123
(Assignee)

Comment 8

6 years ago
Pushed with misbehaving test disabled: http://hg.mozilla.org/mozilla-central/rev/863db843fde4
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.